content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 2098953003: Make cc::CompositorFrames movable [Part 2 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 2098953003: Make cc::CompositorFrames movable [Part 2 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed exo unittests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index 88ea407cb7071d6c6b3539d591e0caf8d6f47146..0570ed67c9855ca3f1f5960d31ff588735a53a5f 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -422,9 +422,7 @@ void RenderWidgetHostViewChildFrame::OnSwapCompositorFrame(

ack_pending_count_++;

// If this value grows very large, something is going wrong.

DCHECK_LT(ack_pending_count_, 1000U);

- std::unique_ptr<cc::CompositorFrame> frame_copy(new cc::CompositorFrame);

- *frame_copy = std::move(frame);

- surface_factory_->SubmitCompositorFrame(surface_id_, std::move(frame_copy),

+ surface_factory_->SubmitCompositorFrame(surface_id_, std::move(frame),

ack_callback);

ProcessFrameSwappedCallbacks();