Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4673)

Unified Diff: cc/surfaces/display.cc

Issue 2098953003: Make cc::CompositorFrames movable [Part 2 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android compiles locally Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/display.cc
diff --git a/cc/surfaces/display.cc b/cc/surfaces/display.cc
index 3709cabb79530490977055028e80983d7c47b854..773fa73d5996f9dda396d6d87bb660f3e9d0a116 100644
--- a/cc/surfaces/display.cc
+++ b/cc/surfaces/display.cc
@@ -226,9 +226,8 @@ bool Display::DrawAndSwap() {
return false;
}
- std::unique_ptr<CompositorFrame> frame =
- aggregator_->Aggregate(current_surface_id_);
- if (!frame) {
+ CompositorFrame frame = aggregator_->Aggregate(current_surface_id_);
+ if (!frame.delegated_frame_data) {
TRACE_EVENT_INSTANT0("cc", "Empty aggregated frame.",
TRACE_EVENT_SCOPE_THREAD);
return false;
@@ -241,11 +240,11 @@ bool Display::DrawAndSwap() {
surface->RunDrawCallbacks(SurfaceDrawStatus::DRAWN);
}
- DelegatedFrameData* frame_data = frame->delegated_frame_data.get();
+ DelegatedFrameData* frame_data = frame.delegated_frame_data.get();
- frame->metadata.latency_info.insert(frame->metadata.latency_info.end(),
- stored_latency_info_.begin(),
- stored_latency_info_.end());
+ frame.metadata.latency_info.insert(frame.metadata.latency_info.end(),
+ stored_latency_info_.begin(),
+ stored_latency_info_.end());
stored_latency_info_.clear();
bool have_copy_requests = false;
for (const auto& pass : frame_data->render_pass_list) {
@@ -300,21 +299,21 @@ bool Display::DrawAndSwap() {
bool should_swap = should_draw && size_matches;
if (should_swap) {
swapped_since_resize_ = true;
- for (auto& latency : frame->metadata.latency_info) {
+ for (auto& latency : frame.metadata.latency_info) {
TRACE_EVENT_WITH_FLOW1("input,benchmark", "LatencyInfo.Flow",
TRACE_ID_DONT_MANGLE(latency.trace_id()),
TRACE_EVENT_FLAG_FLOW_IN | TRACE_EVENT_FLAG_FLOW_OUT,
"step", "Display::DrawAndSwap");
}
benchmark_instrumentation::IssueDisplayRenderingStatsEvent();
- renderer_->SwapBuffers(std::move(frame->metadata));
+ renderer_->SwapBuffers(std::move(frame.metadata));
} else {
if (have_damage && !size_matches)
aggregator_->SetFullDamageForSurface(current_surface_id_);
TRACE_EVENT_INSTANT0("cc", "Swap skipped.", TRACE_EVENT_SCOPE_THREAD);
stored_latency_info_.insert(stored_latency_info_.end(),
- frame->metadata.latency_info.begin(),
- frame->metadata.latency_info.end());
+ frame.metadata.latency_info.begin(),
+ frame.metadata.latency_info.end());
DidSwapBuffers();
DidSwapBuffersComplete();
}

Powered by Google App Engine
This is Rietveld 408576698