masters/master.chromium.win/master_win_cfg.py - Issue 2098943002: Rename Mac/Win GN builders to GYP builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: masters/master.chromium.win/master_win_cfg.py

Issue 2098943002: Rename Mac/Win GN builders to GYP builders. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: fix typo, add recipe expectations for new builders Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: masters/master.chromium.win/master_win_cfg.py

diff --git a/masters/master.chromium.win/master_win_cfg.py b/masters/master.chromium.win/master_win_cfg.py

index 3d1aa35ec1b25fc1870df04663d6f201f31d99e3..dd7f6b5b2f07ea166e8fa0a69ab246d5325822e7 100644

--- a/masters/master.chromium.win/master_win_cfg.py

+++ b/masters/master.chromium.win/master_win_cfg.py

@@ -19,9 +19,9 @@ def Update(config, active_master, c):

'Win x64 Builder',

'Win x64 Builder (dbg)',

'Win Builder (dbg)',

- 'Win8 GN (dbg)',

+ 'Win8 GYP (dbg)',

'WinClang64 (dbg)',

- 'Win8 Aura',

+ 'Win8 GYP',

]),

])

specs = [

@@ -33,8 +33,8 @@ def Update(config, active_master, c):

{'name': 'Win x64 Builder (dbg)'},

{'name': 'Win Builder (dbg)'},

{'name': 'Win7 Tests (dbg)(1)'},

- {'name': 'Win8 Aura'},

Robert Sesek 2016/06/24 21:34:10 Why is Aura getting changed here?

Dirk Pranke 2016/06/24 21:46:08 Because that's really been "Win8 GN" for a long ti

- {'name': 'Win8 GN (dbg)'},

+ {'name': 'Win8 GYP'},

+ {'name': 'Win8 GYP (dbg)'},

{'name': 'WinClang64 (dbg)'},

{'name': 'Win10 Tests x64'},

]

« no previous file with comments | « masters/master.chromium.mac/slaves.cfg ('k') | masters/master.chromium.win/slaves.cfg » ('j') | no next file with comments »