Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2098943002: Rename Mac/Win GN builders to GYP builders. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek, martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Rename Mac/Win GN builders to GYP builders. Now that the main Mac and Win builders are on GN, the builders with "GN" in the names are redundant and confusing. This CL renames them and the corresponding trybots to "GYP" to provide some GYP coverage until we drop the GYP build completely. There are matching trybots for the builders, but they are not part of the commit queue. - chromium.mac - "Mac GN" -> "Mac GYP" - "Mac GN (dbg)" -> "Mac GYP (dbg)" - chromium.win - "Win8 Aura" -> "Win8 GYP" (Aura has been default for a long time) - "Win8 GN (dbg) -> "Win8 GYP (dbg)" - tryserver.chromium.mac - mac_chromium_rel_ng -> mac_chromium_gyp_rel - mac_chromium_dbg_ng -> mac_chromium_gyp_dbg - tryserver.chromium.win - win8_chromium_ng -> win8_chromium_gyp_rel - win8_chromium_gn_dbg -> win8_chromium_gyp_dbg R=rsesek@chromium.org BUG=618468, 605318 Committed: https://chromium.googlesource.com/chromium/tools/build/+/11582d2d7d07ac1409907a39ed823b68a9916271

Patch Set 1 : code changes #

Patch Set 2 : fix typo, add recipe expectations for new builders #

Total comments: 2

Patch Set 3 : fix masters_recipes_test.py to handle deprecated builders #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -52 lines) Patch
M masters/master.chromium.mac/master_mac_cfg.py View 2 chunks +4 lines, -4 lines 0 comments Download
M masters/master.chromium.mac/slaves.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.win/master_win_cfg.py View 2 chunks +4 lines, -4 lines 0 comments Download
M masters/master.chromium.win/slaves.cfg View 2 chunks +2 lines, -2 lines 0 comments Download
M masters/master.tryserver.chromium.mac/master.cfg View 1 chunk +4 lines, -4 lines 0 comments Download
M masters/master.tryserver.chromium.mac/slaves.cfg View 1 chunk +2 lines, -2 lines 0 comments Download
M masters/master.tryserver.chromium.win/master.cfg View 1 chunk +4 lines, -4 lines 0 comments Download
M masters/master.tryserver.chromium.win/slaves.cfg View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_mac.py View 2 chunks +38 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_win.py View 1 3 chunks +44 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 2 chunks +21 lines, -1 line 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_GYP.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_GYP__dbg_.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_gyp_dbg.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_gyp_rel.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_gyp_dbg.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_gyp_rel.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/masters_recipes_test.py View 1 2 4 chunks +33 lines, -3 lines 2 comments Download

Messages

Total messages: 17 (8 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-24 21:26:31 UTC) #3
Robert Sesek
Mostly lgtm but I am not an expert. https://codereview.chromium.org/2098943002/diff/40001/masters/master.chromium.win/master_win_cfg.py File masters/master.chromium.win/master_win_cfg.py (left): https://codereview.chromium.org/2098943002/diff/40001/masters/master.chromium.win/master_win_cfg.py#oldcode36 masters/master.chromium.win/master_win_cfg.py:36: {'name': ...
4 years, 6 months ago (2016-06-24 21:34:10 UTC) #4
Dirk Pranke
https://codereview.chromium.org/2098943002/diff/40001/masters/master.chromium.win/master_win_cfg.py File masters/master.chromium.win/master_win_cfg.py (left): https://codereview.chromium.org/2098943002/diff/40001/masters/master.chromium.win/master_win_cfg.py#oldcode36 masters/master.chromium.win/master_win_cfg.py:36: {'name': 'Win8 Aura'}, On 2016/06/24 21:34:10, Robert Sesek wrote: ...
4 years, 6 months ago (2016-06-24 21:46:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098943002/40001
4 years, 6 months ago (2016-06-24 22:21:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/5715)
4 years, 6 months ago (2016-06-24 22:29:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098943002/60001
4 years, 6 months ago (2016-06-24 23:05:21 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/tools/build/+/11582d2d7d07ac1409907a39ed823b68a9916271
4 years, 6 months ago (2016-06-24 23:09:44 UTC) #14
martiniss
https://codereview.chromium.org/2098943002/diff/60001/tests/masters_recipes_test.py File tests/masters_recipes_test.py (right): https://codereview.chromium.org/2098943002/diff/60001/tests/masters_recipes_test.py#newcode186 tests/masters_recipes_test.py:186: import pdb; pdb.set_trace() Left in some debug code.
4 years, 6 months ago (2016-06-25 04:39:49 UTC) #16
Dirk Pranke
4 years, 6 months ago (2016-06-25 04:45:37 UTC) #17
Message was sent while issue was closed.
https://codereview.chromium.org/2098943002/diff/60001/tests/masters_recipes_t...
File tests/masters_recipes_test.py (right):

https://codereview.chromium.org/2098943002/diff/60001/tests/masters_recipes_t...
tests/masters_recipes_test.py:186: import pdb; pdb.set_trace()
On 2016/06/25 04:39:49, martiniss wrote:
> Left in some debug code.

Ah, so I did. Good thing it doesn't fire :).

I'll fix it when I revert these changes after the builders are fixed.

Powered by Google App Engine
This is Rietveld 408576698