Source/bindings/tests/results/V8TestInterfacePython2.cpp - Issue 209893002: Custom wrap constructor overloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfacePython2.cpp

Issue 209893002: Custom wrap constructor overloads. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code tweak Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfacePython2.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfacePython2.cpp b/Source/bindings/tests/results/V8TestInterfacePython2.cpp

index 35f580dc7dae46d7dc4bec3ff8dd98942f4a8032..64c4af46379efb71c55eb8bc48c67578a0fc8601 100644

--- a/Source/bindings/tests/results/V8TestInterfacePython2.cpp

+++ b/Source/bindings/tests/results/V8TestInterfacePython2.cpp

@@ -80,9 +80,8 @@ template <typename T> void V8_USE(T) { }

static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

{

RefPtr<TestInterfacePython2> impl = TestInterfacePython2::create();

- v8::Handle<v8::Object> wrapper = info.Holder();

- V8DOMWrapper::associateObjectWithWrapper<V8TestInterfacePython2>(impl.release(), &V8TestInterfacePython2::wrapperTypeInfo, wrapper, info.GetIsolate(), WrapperConfiguration::Dependent);

+ v8::Handle<v8::Object> wrapper = wrap(impl.get(), info.Holder(), info.GetIsolate());

v8SetReturnValue(info, wrapper);

}