Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp - Issue 209893002: Custom wrap constructor overloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

Issue 209893002: Custom wrap constructor overloads. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code tweak Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceConstructor.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp b/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

index fb6a4ea5c4ef37d7ed4bffb832a21bb2bb4d9459..4a8f9642e59e1a160a0b4be014ab0a4bdabc2c6a 100644

--- a/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

@@ -79,8 +79,8 @@ static void constructor1(const v8::FunctionCallbackInfo<v8::Value>& info)

{

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, stringArg, info[0]);

RefPtr<TestInterfaceConstructor2> impl = TestInterfaceConstructor2::create(stringArg);

- v8::Handle<v8::Object> wrapper = info.Holder();

+ v8::Handle<v8::Object> wrapper = info.Holder();

V8DOMWrapper::associateObjectWithWrapper<V8TestInterfaceConstructor2>(impl.release(), &V8TestInterfaceConstructor2::wrapperTypeInfo, wrapper, info.GetIsolate(), WrapperConfiguration::Independent);

v8SetReturnValue(info, wrapper);

}

@@ -99,8 +99,8 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info)

return;

}

RefPtr<TestInterfaceConstructor2> impl = TestInterfaceConstructor2::create(testInterfaceEmptyArg, longArg, defaultUndefinedOptionalStringArg, defaultNullStringOptionalStringArg, defaultUndefinedOptionalDictionaryArg);

- v8::Handle<v8::Object> wrapper = info.Holder();

+ v8::Handle<v8::Object> wrapper = info.Holder();

V8DOMWrapper::associateObjectWithWrapper<V8TestInterfaceConstructor2>(impl.release(), &V8TestInterfaceConstructor2::wrapperTypeInfo, wrapper, info.GetIsolate(), WrapperConfiguration::Independent);

v8SetReturnValue(info, wrapper);

}