Custom wrap constructor overloads.

Source/bindings/templates/methods.cpp

 {##############################################################################}
 {% macro generate_method(method, world_suffix) %}
 {% filter conditional(method.conditional_string) %}
 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     {# Local variables #}
     {% if method.has_exception_state %}
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.name}}", "{{interface_name}}", info.Holder(), info.GetIsolate());
     {% endif %}
     {% if method.number_of_required_arguments %}
@@ skipping 368 matching lines @@
     {% for argument in constructor.arguments %}
     {{generate_argument(constructor, argument) | indent}}
     {% endfor %}
     {% if is_constructor_call_with_execution_context %}
     ExecutionContext* context = currentExecutionContext(info.GetIsolate());
     {% endif %}
     {% if is_constructor_call_with_document %}
     Document& document = *toDocument(currentExecutionContext(info.GetIsolate()));
     {% endif %}
     {{ref_ptr}}<{{cpp_class}}> impl = {{cpp_class}}::create({{constructor.argument_list | join(', ')}});
-    v8::Handle<v8::Object> wrapper = info.Holder();
     {% if is_constructor_raises_exception %}
     if (exceptionState.throwIfNeeded())
         return;
     {% endif %}
 
+    {% if has_custom_wrap %}
+    v8SetReturnValue(info, wrap(impl.get(), info.Holder(), info.GetIsolate()));
+    {% else %}
+    v8::Handle<v8::Object> wrapper = info.Holder();
     V8DOMWrapper::associateObjectWithWrapper<{{v8_class}}>(impl.release(), &{{v8_class}}::wrapperTypeInfo, wrapper, info.GetIsolate(), {{wrapper_configuration}});
     v8SetReturnValue(info, wrapper);

[Nils Barth (inactive), 2014/03/24 08:50:26]

I don't follow how this differs from what I committed;
I put the v8SetReturnValue call *after* the if,
so for [Custom=Wrap] wrap() is called to generate the wrapper,
but both use the same v8SetReturnValue call.

[Nils Barth (inactive), 2014/03/24 08:55:00]

OIC, I did it for *named* constructors.
Could you factor out the wrapper as I did?
v8::Handle<v8::Object> wrapper = wrap(impl.get(), info.Holder(),
info.GetIsolate());
...and then the v8SetReturnValue *after* the if?

+    {% endif %}
 }
 {% endmacro %}
 
 
 {##############################################################################}
 {% macro named_constructor_callback(constructor) %}
 static void {{v8_class}}ConstructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (!info.IsConstructCall()) {
         throwTypeError(ExceptionMessages::failedToConstruct("{{constructor.name}}", "Please use the 'new' operator, this DOM object constructor cannot be called as a function."), info.GetIsolate());
@@ skipping 34 matching lines @@
 
     {% if has_custom_wrap %}
     v8::Handle<v8::Object> wrapper = wrap(impl.get(), info.Holder(), info.GetIsolate());
     {% else %}
     v8::Handle<v8::Object> wrapper = info.Holder();
     V8DOMWrapper::associateObjectWithWrapper<{{v8_class}}>(impl.release(), &{{v8_class}}Constructor::wrapperTypeInfo, wrapper, info.GetIsolate(), {{wrapper_configuration}});
     {% endif %}
     v8SetReturnValue(info, wrapper);
 }
 {% endmacro %}