Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 2098923002: Remove dependency of ResourceDispatcherHostImpl on RenderViewHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.h ('k') | content/browser/loader_delegate_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_dispatcher_host_impl.cc
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index a0855984d17f5fd4f65acf0b6e5be3146c1a9b68..df7096dfecdf11835df8289a0725d672fa3f998f 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -49,6 +49,7 @@
#include "content/browser/loader/async_revalidation_manager.h"
#include "content/browser/loader/cross_site_resource_handler.h"
#include "content/browser/loader/detachable_resource_handler.h"
+#include "content/browser/loader/loader_delegate.h"
#include "content/browser/loader/mime_type_resource_handler.h"
#include "content/browser/loader/navigation_resource_handler.h"
#include "content/browser/loader/navigation_resource_throttle.h"
@@ -61,7 +62,6 @@
#include "content/browser/loader/sync_resource_handler.h"
#include "content/browser/loader/throttling_resource_handler.h"
#include "content/browser/loader/upload_data_stream_builder.h"
-#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/resource_context_impl.h"
#include "content/browser/service_worker/foreign_fetch_request_handler.h"
#include "content/browser/service_worker/link_header_support.h"
@@ -547,8 +547,9 @@ ResourceDispatcherHostImpl::ResourceDispatcherHostImpl()
max_num_in_flight_requests_ * kMaxRequestsPerProcessRatio)),
max_outstanding_requests_cost_per_process_(
kMaxOutstandingRequestsCostPerProcess),
- filter_(NULL),
- delegate_(NULL),
+ filter_(nullptr),
+ delegate_(nullptr),
+ loader_delegate_(nullptr),
allow_cross_origin_auth_prompt_(false),
cert_store_for_testing_(nullptr) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -2310,6 +2311,11 @@ void ResourceDispatcherHostImpl::EnableStaleWhileRevalidateForTesting() {
async_revalidation_manager_.reset(new AsyncRevalidationManager);
}
+void ResourceDispatcherHostImpl::SetLoaderDelegate(
+ LoaderDelegate* loader_delegate) {
+ loader_delegate_ = loader_delegate;
+}
+
// static
int ResourceDispatcherHostImpl::CalculateApproximateMemoryCost(
net::URLRequest* request) {
@@ -2425,27 +2431,6 @@ bool ResourceDispatcherHostImpl::LoadInfoIsMoreInteresting(const LoadInfo& a,
return a.load_state.state > b.load_state.state;
}
-// static
-void ResourceDispatcherHostImpl::UpdateLoadInfoOnUIThread(
- std::unique_ptr<LoadInfoMap> info_map) {
- // TODO(erikchen): Remove ScopedTracker below once http://crbug.com/466285
- // is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "466285 ResourceDispatcherHostImpl::UpdateLoadInfoOnUIThread"));
- DCHECK_CURRENTLY_ON(BrowserThread::UI);
- for (const auto& load_info : *info_map) {
- RenderViewHostImpl* view = RenderViewHostImpl::FromID(
- load_info.first.child_id, load_info.first.route_id);
- // The view could be gone at this point.
- if (view) {
- view->LoadStateChanged(load_info.second.url, load_info.second.load_state,
- load_info.second.upload_position,
- load_info.second.upload_size);
- }
- }
-}
-
std::unique_ptr<ResourceDispatcherHostImpl::LoadInfoMap>
ResourceDispatcherHostImpl::GetLoadInfoForAllRoutes() {
// Populate this map with load state changes, and then send them on to the UI
@@ -2485,10 +2470,12 @@ void ResourceDispatcherHostImpl::UpdateLoadInfo() {
return;
}
- BrowserThread::PostTask(
- BrowserThread::UI, FROM_HERE,
- base::Bind(&ResourceDispatcherHostImpl::UpdateLoadInfoOnUIThread,
- base::Passed(&info_map)));
+ for (const auto& load_info : *info_map) {
+ loader_delegate_->LoadStateChanged(
+ load_info.first.child_id, load_info.first.route_id,
+ load_info.second.url, load_info.second.load_state,
+ load_info.second.upload_position, load_info.second.upload_size);
+ }
}
void ResourceDispatcherHostImpl::BlockRequestsForRoute(
« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.h ('k') | content/browser/loader_delegate_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698