Remove dependency of ResourceDispatcherHostImpl on RenderViewHostImpl

content/browser/loader/loader_delegate.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_LOADER_LOADER_DELEGATE_H_
+#define CONTENT_BROWSER_LOADER_LOADER_DELEGATE_H_
+
+#include <inttypes.h>
+
+#include "content/browser/loader/global_routing_id.h"

[jam, 2016/06/28 16:23:49]

nit: how about just sending child_id and route_id instead of using
GlobalRoutingID? that avoids introducing a dependency on this header from
outside the loader code.

[scottmg, 2016/06/28 18:33:38]

Done.

+#include "net/base/load_states.h"
+
+class GURL;
+
+namespace content {
+
+// Delegate from loader to the rest of content. Lives on the IO thread.

[jam, 2016/06/28 16:23:49]

nit: to help others understand how this differs from other delegates in the
loader code, please add something to the effect of:

This is used for breaking dependency from files in content/browser/loader
that'll be moved to a separate networking service. All methods here should be
asynchronous since eventually this will be a Mojo interface once the networking
code runs in a separate process. http://crbug.com/622050

[scottmg, 2016/06/28 18:33:38]

Done.

+class LoaderDelegate {
+ public:
+  virtual ~LoaderDelegate() {}
+
+  virtual void LoadStateChanged(const GlobalRoutingID& routing_id,

[jam, 2016/06/28 16:23:49]

nit: please document

[scottmg, 2016/06/28 18:33:38]

Done.

+                                const GURL& url,
+                                const net::LoadStateWithParam& load_state,
+                                uint64_t upload_position,
+                                uint64_t upload_size) = 0;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_LOADER_LOADER_DELEGATE_H_