Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2098823003: Add IPC serialization support for base::Optional (Closed)

Created:
4 years, 6 months ago by Bryan McQuade
Modified:
4 years, 5 months ago
Reviewers:
dcheng
CC:
chromium-reviews, darin-cc_chromium.org, jam, mounirri_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IPC serialization support for base::Optional As part of bug 623556, we need to update one of our IPC structs to use Optional. We unfortunately can't migrate to mojo at this time because our IPCs depend on delivery order relative to other IPCs (in particular, FrameHostMsg_DidCommitProvisionalLoad). Additional details on ordering constraints are covered in https://docs.google.com/document/d/1HJsJ5W2H_3qRdqPAUgAEo10AF8gXPTXZLUET4X4_sII/edit. As a result, I'd like to add IPC serialization support for Optional so we can unblock progress on bug 623556. BUG=623556 Committed: https://crrev.com/18573e16ba6fd3240514d661da4b64ffc0e82da8 Cr-Commit-Position: refs/heads/master@{#403442}

Patch Set 1 #

Patch Set 2 : add basic ipc serialization test #

Patch Set 3 : use move #

Patch Set 4 : cleanup #

Patch Set 5 : more cleanup #

Patch Set 6 : revert non IPC parts of patch #

Patch Set 7 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -1 line) Patch
M ipc/ipc_message_utils.h View 1 2 3 4 3 chunks +39 lines, -1 line 0 comments Download
M ipc/ipc_message_utils_unittest.cc View 1 2 3 4 5 6 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Bryan McQuade
dcheng, here's the patch I'd mentioned over email. Please take a look. Thanks!
4 years, 5 months ago (2016-06-30 11:56:33 UTC) #10
dcheng
lgtm
4 years, 5 months ago (2016-07-01 02:24:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098823003/120001
4 years, 5 months ago (2016-07-01 11:56:29 UTC) #13
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-07-01 13:14:02 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 13:14:09 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 13:15:41 UTC) #17
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/18573e16ba6fd3240514d661da4b64ffc0e82da8
Cr-Commit-Position: refs/heads/master@{#403442}

Powered by Google App Engine
This is Rietveld 408576698