Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2098773003: [Mac/GN] Add missing import //build/config/zip.gni after cf63a9a5e547. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Add missing import //build/config/zip.gni after cf63a9a5e547. BUG=618468 TBR=dpranke@chromium.org NOTRY=true Committed: https://crrev.com/2aab097442f421ec9d878ff0fe6f7a5f1895d261 Cr-Commit-Position: refs/heads/master@{#401914}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M remoting/host/BUILD.gn View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Robert Sesek
https://codereview.chromium.org/2098773003/diff/1/remoting/host/BUILD.gn File remoting/host/BUILD.gn (right): https://codereview.chromium.org/2098773003/diff/1/remoting/host/BUILD.gn#newcode1153 remoting/host/BUILD.gn:1153: # ":remoting_me2me_host", FAILED: remoting_me2me_host remoting_me2me_host.dSYM TOOL_VERSION=1466186746 ../../build/toolchain/mac/linker_driver.py /Users/rsesek/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ ...
4 years, 6 months ago (2016-06-24 18:40:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098773003/1
4 years, 6 months ago (2016-06-24 18:41:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 18:50:03 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2aab097442f421ec9d878ff0fe6f7a5f1895d261 Cr-Commit-Position: refs/heads/master@{#401914}
4 years, 6 months ago (2016-06-24 18:52:17 UTC) #6
Dirk Pranke
4 years, 6 months ago (2016-06-24 18:53:40 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698