Issue 209873004: Fix component build some more.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209873004: Fix component build some more. (Closed)

Created:
6 years, 9 months ago by marja

Modified:
6 years, 9 months ago

Reviewers:
dcarney

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix component build some more. Not V8_EXPORTing ScriptCompiler::Source got rid of the last errors. This fixes the new ones created by it. V8_INLINEing these funcs makes sense anyway. In addition, added declared-private-and-unimplemented assignment operators which were accidentally omitted. R=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20188

Patch Set 1 #

Patch Set 2 : rebased #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -30 lines)			Patch
	M	include/v8.h	View	1	3 chunks	+33 lines, -4 lines	0 comments	Download
	M	src/api.cc	View	1	1 chunk	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

marja

6 years, 9 months ago (2014-03-24 12:14:03 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r20188 (presubmit successful).

Expand Messages | Collapse Messages