Unwind the fallback admin policy knobs.

Unwind the fallback admin policy knobs.

Part 1 of removing the TLS version fallback code. Later commits will unwind
other pieces.

The admin policy has expired, so there is no need to keep the code around.

BUG=621780
Committed: https://crrev.com/4d0b082a62056eed2affe714b07e1324582f7af9
Cr-Commit-Position: refs/heads/master@{#402310}

[davidben, 2016-06-24 00:16:54]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2016-06-24 00:43:19]

The compile failures should be your guide :)

[davidben, 2016-06-24 00:51:39]

On 2016/06/24 00:43:19, Ryan Sleevi wrote:
> The compile failures should be your guide :)

Oops. I only rebuilt components. Fixed, hopefully.

[Ryan Sleevi, 2016-06-24 01:01:04]

LGTM % one question

https://codereview.chromium.org/2098723002/diff/20001/chrome/test/data/policy...
File chrome/test/data/policy/policy_test_cases.json (left):

https://codereview.chromium.org/2098723002/diff/20001/chrome/test/data/policy...
chrome/test/data/policy/policy_test_cases.json:1864: "SSLVersionFallbackMin": {
Why did you leave this empty? Instead of removing it entirely?

[davidben, 2016-06-24 02:10:35]

https://codereview.chromium.org/2098723002/diff/20001/chrome/test/data/policy...
File chrome/test/data/policy/policy_test_cases.json (left):

https://codereview.chromium.org/2098723002/diff/20001/chrome/test/data/policy...
chrome/test/data/policy/policy_test_cases.json:1864: "SSLVersionFallbackMin": {
On 2016/06/24 01:01:03, Ryan Sleevi wrote:
> Why did you leave this empty? Instead of removing it entirely?

The others do it too. policy_templates.json entries don't get removed and I
believe something gets unhappy if there isn't a corresponding entry or
something. It's weird.

[davidben, 2016-06-24 17:36:24]

Description was changed from

==========
Unwind the fallback admin policy knobs.

Part 1 of removing the TLS version fallback code. Later commits will unwind
other pieces.

BUG=621780
==========

to

==========
Unwind the fallback admin policy knobs.

Part 1 of removing the TLS version fallback code. Later commits will unwind
other pieces.

The admin policy has expired, so there is no need to keep the code around.

BUG=621780
==========

[davidben, 2016-06-24 17:36:36]

davidben@chromium.org changed reviewers:
+ battre@chromium.org, pastarmovj@chromium.org

[davidben, 2016-06-24 17:36:37]

+battre for chrome/browser/prefs
+pastarmovj for chrome/browser/policy

[pastarmovj, 2016-06-27 08:20:07]

LGTM with a nit: Please also set the 'deprecated' flag to True for this policy
here:
https://cs.chromium.org/chromium/src/components/policy/resources/policy_templ...

The file is already a little inconsistent in its use of this flag on removed
policies but from a quick glance over the removed ones the most of them seem to
have this flag also set. Eventually we might find a good way to remove obsolete
policies from this file completely but for now it is impossible. This is also
why you can't remove the empty test as it expects to fine one test for each
policy in this file no matter whether it does anything or not.

[battre, 2016-06-27 08:27:18]

lgtm

[davidben, 2016-06-27 19:42:10]

On 2016/06/27 08:20:07, pastarmovj wrote:
> LGTM with a nit: Please also set the 'deprecated' flag to True for this policy
> here:
>
https://cs.chromium.org/chromium/src/components/policy/resources/policy_templ...
> 
> The file is already a little inconsistent in its use of this flag on removed
> policies but from a quick glance over the removed ones the most of them seem
to
> have this flag also set. Eventually we might find a good way to remove
obsolete
> policies from this file completely but for now it is impossible. This is also
> why you can't remove the empty test as it expects to fine one test for each
> policy in this file no matter whether it does anything or not.

Done.

[davidben, 2016-06-27 19:43:35]

On 2016/06/27 19:42:10, davidben wrote:
> On 2016/06/27 08:20:07, pastarmovj wrote:
> > LGTM with a nit: Please also set the 'deprecated' flag to True for this
policy
> > here:
> >
>
https://cs.chromium.org/chromium/src/components/policy/resources/policy_templ...
> > 
> > The file is already a little inconsistent in its use of this flag on removed
> > policies but from a quick glance over the removed ones the most of them seem
> to
> > have this flag also set. Eventually we might find a good way to remove
> obsolete
> > policies from this file completely but for now it is impossible. This is
also
> > why you can't remove the empty test as it expects to fine one test for each
> > policy in this file no matter whether it does anything or not.
> 
> Done.

(Er, got my branches confused. Will be done in a moment.)

[davidben, 2016-06-27 19:45:59]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-06-27 19:46:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
pastarmovj@chromium.org, rsleevi@chromium.org, battre@chromium.org
Link to the patchset: https://codereview.chromium.org/2098723002/#ps40001
(title: "Add deprecated markers")

[commit-bot: I haz the power, 2016-06-27 19:47:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 19:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 19:50:43]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[davidben, 2016-06-27 20:31:26]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-06-27 20:31:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
pastarmovj@chromium.org, rsleevi@chromium.org, battre@chromium.org
Link to the patchset: https://codereview.chromium.org/2098723002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-27 20:32:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 22:04:56]

Description was changed from

==========
Unwind the fallback admin policy knobs.

Part 1 of removing the TLS version fallback code. Later commits will unwind
other pieces.

The admin policy has expired, so there is no need to keep the code around.

BUG=621780
==========

to

==========
Unwind the fallback admin policy knobs.

Part 1 of removing the TLS version fallback code. Later commits will unwind
other pieces.

The admin policy has expired, so there is no need to keep the code around.

BUG=621780
==========

[commit-bot: I haz the power, 2016-06-27 22:04:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-27 22:06:16]

Description was changed from

==========
Unwind the fallback admin policy knobs.

Part 1 of removing the TLS version fallback code. Later commits will unwind
other pieces.

The admin policy has expired, so there is no need to keep the code around.

BUG=621780
==========

to

==========
Unwind the fallback admin policy knobs.

Part 1 of removing the TLS version fallback code. Later commits will unwind
other pieces.

The admin policy has expired, so there is no need to keep the code around.

BUG=621780

Committed: https://crrev.com/4d0b082a62056eed2affe714b07e1324582f7af9
Cr-Commit-Position: refs/heads/master@{#402310}
==========

[commit-bot: I haz the power, 2016-06-27 22:06:17]

Patchset 4 (id:??) landed as
https://crrev.com/4d0b082a62056eed2affe714b07e1324582f7af9
Cr-Commit-Position: refs/heads/master@{#402310}