Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2098713003: Moved a bunch of win-specific files to the new win folder in chrome/browser (Closed)

Created:
4 years, 6 months ago by Patrick Monette
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved a bunch of win-specific files to the new win folder in chrome/browser Committed: https://crrev.com/23c8fb7e2bd350658ae97ffc955428fd1986e9f9 Cr-Commit-Position: refs/heads/master@{#402274}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -4405 lines) Patch
M chrome/app/chrome_exe_main_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/OWNERS View 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/app_icon_win.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/app_icon_win.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/browser_util_win.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/browser_util_win.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/chrome_elf_init_unittest_win.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D chrome/browser/chrome_elf_init_win.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/chrome_elf_init_win.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D chrome/browser/chrome_process_finder_win.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/chrome_process_finder_win.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/chrome_select_file_dialog_factory_win.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/chrome_select_file_dialog_factory_win.cc View 1 chunk +0 lines, -322 lines 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/enumerate_modules_model_unittest_win.cc View 1 chunk +0 lines, -243 lines 0 comments Download
D chrome/browser/enumerate_modules_model_win.h View 1 chunk +0 lines, -366 lines 0 comments Download
D chrome/browser/enumerate_modules_model_win.cc View 1 chunk +0 lines, -1082 lines 0 comments Download
D chrome/browser/jumplist_updater_win.h View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/jumplist_updater_win.cc View 1 chunk +0 lines, -244 lines 0 comments Download
D chrome/browser/jumplist_win.h View 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/browser/jumplist_win.cc View 1 chunk +0 lines, -590 lines 0 comments Download
D chrome/browser/private_working_set_snapshot.h View 1 chunk +0 lines, -122 lines 0 comments Download
D chrome/browser/private_working_set_snapshot_win.cc View 1 chunk +0 lines, -189 lines 0 comments Download
D chrome/browser/private_working_set_snapshot_win_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_win_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/app_menu_icon_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/conflicting_module_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_icon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/conflicts_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/win/OWNERS View 1 chunk +7 lines, -0 lines 0 comments Download
A + chrome/browser/win/app_icon.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/win/app_icon.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/win/browser_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/win/browser_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/win/chrome_elf_init.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/win/chrome_elf_init.cc View 2 chunks +2 lines, -1 line 0 comments Download
A + chrome/browser/win/chrome_elf_init_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/win/chrome_process_finder.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/win/chrome_process_finder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/win/chrome_select_file_dialog_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/win/chrome_select_file_dialog_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/win/enumerate_modules_model.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/win/enumerate_modules_model.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/win/enumerate_modules_model_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/browser/win/jumplist.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/win/jumplist.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/win/jumplist_updater.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/win/jumplist_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/win/private_working_set_snapshot.h View 2 chunks +3 lines, -6 lines 0 comments Download
A + chrome/browser/win/private_working_set_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/win/private_working_set_snapshot_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 7 chunks +16 lines, -16 lines 0 comments Download
M chrome/chrome_process_finder.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 4 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Patrick Monette
PTAL This CL doesn't make any logic changes.
4 years, 6 months ago (2016-06-23 23:58:09 UTC) #2
sky
https://codereview.chromium.org/2098713003/diff/1/chrome/browser/win/chrome_process_finder.h File chrome/browser/win/chrome_process_finder.h (right): https://codereview.chromium.org/2098713003/diff/1/chrome/browser/win/chrome_process_finder.h#newcode17 chrome/browser/win/chrome_process_finder.h:17: namespace win { Don't bother with the win namespace ...
4 years, 6 months ago (2016-06-24 15:58:17 UTC) #3
Patrick Monette
https://codereview.chromium.org/2098713003/diff/1/chrome/browser/win/chrome_process_finder.h File chrome/browser/win/chrome_process_finder.h (right): https://codereview.chromium.org/2098713003/diff/1/chrome/browser/win/chrome_process_finder.h#newcode17 chrome/browser/win/chrome_process_finder.h:17: namespace win { On 2016/06/24 15:58:17, sky wrote: > ...
4 years, 5 months ago (2016-06-27 17:43:12 UTC) #4
sky
LGTM
4 years, 5 months ago (2016-06-27 20:35:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098713003/20001
4 years, 5 months ago (2016-06-27 20:37:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 20:45:30 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 20:46:46 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/23c8fb7e2bd350658ae97ffc955428fd1986e9f9
Cr-Commit-Position: refs/heads/master@{#402274}

Powered by Google App Engine
This is Rietveld 408576698