Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2098703003: DevTools: protocol setting files properly handles mimetypes and directories. (Closed)

Created:
4 years, 6 months ago by einbinder
Modified:
4 years, 5 months ago
Reviewers:
tkent, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-html_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: protocol setting files properly handles mimetypes and directories. BUG=620367 Committed: https://crrev.com/7377ed7748106955dadd95ab254ddd86ae411c16 Cr-Commit-Position: refs/heads/master@{#403524}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Refactor to FileInputType, add test #

Total comments: 4

Patch Set 3 : make paths const #

Total comments: 1

Patch Set 4 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -16 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElement.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.cpp View 1 2 2 chunks +19 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputTypeTest.cpp View 1 2 chunks +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
einbinder
4 years, 6 months ago (2016-06-23 23:58:58 UTC) #2
dgozman
Can we have a test? +tkent for core/html/forms. Could you please take a look? https://codereview.chromium.org/2098703003/diff/1/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ...
4 years, 6 months ago (2016-06-24 18:45:04 UTC) #5
tkent
https://codereview.chromium.org/2098703003/diff/1/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp (right): https://codereview.chromium.org/2098703003/diff/1/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp#newcode1335 third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp:1335: FileList* fileList = FileList::create(); IMO, the code below should ...
4 years, 5 months ago (2016-06-27 02:08:34 UTC) #6
einbinder
ptal https://codereview.chromium.org/2098703003/diff/1/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp (right): https://codereview.chromium.org/2098703003/diff/1/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp#newcode1335 third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp:1335: FileList* fileList = FileList::create(); On 2016/06/27 02:08:33, tkent ...
4 years, 5 months ago (2016-06-27 20:58:57 UTC) #7
dgozman
looks good from inspector side https://codereview.chromium.org/2098703003/diff/20001/third_party/WebKit/Source/core/html/HTMLInputElement.h File third_party/WebKit/Source/core/html/HTMLInputElement.h (right): https://codereview.chromium.org/2098703003/diff/20001/third_party/WebKit/Source/core/html/HTMLInputElement.h#newcode189 third_party/WebKit/Source/core/html/HTMLInputElement.h:189: void setFilesFromPaths(Vector<String>); const Vector<String>& ...
4 years, 5 months ago (2016-06-27 21:07:02 UTC) #8
einbinder
https://codereview.chromium.org/2098703003/diff/20001/third_party/WebKit/Source/core/html/HTMLInputElement.h File third_party/WebKit/Source/core/html/HTMLInputElement.h (right): https://codereview.chromium.org/2098703003/diff/20001/third_party/WebKit/Source/core/html/HTMLInputElement.h#newcode189 third_party/WebKit/Source/core/html/HTMLInputElement.h:189: void setFilesFromPaths(Vector<String>); On 2016/06/27 21:07:02, dgozman wrote: > const ...
4 years, 5 months ago (2016-06-27 22:41:02 UTC) #9
tkent
lgtm https://codereview.chromium.org/2098703003/diff/40001/third_party/WebKit/Source/core/html/HTMLInputElement.cpp File third_party/WebKit/Source/core/html/HTMLInputElement.cpp (right): https://codereview.chromium.org/2098703003/diff/40001/third_party/WebKit/Source/core/html/HTMLInputElement.cpp#newcode1921 third_party/WebKit/Source/core/html/HTMLInputElement.cpp:1921: nit: Add a blank line between }s, not ...
4 years, 5 months ago (2016-06-27 23:10:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098703003/60001
4 years, 5 months ago (2016-07-01 19:38:38 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-01 20:55:48 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 20:55:50 UTC) #16
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/7377ed7748106955dadd95ab254ddd86ae411c16 Cr-Commit-Position: refs/heads/master@{#403524}
4 years, 5 months ago (2016-07-01 20:58:51 UTC) #18
einbinder
4 years, 5 months ago (2016-07-01 22:19:39 UTC) #19
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2119863003/ by einbinder@chromium.org.

The reason for reverting is: Failed
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/w....

Powered by Google App Engine
This is Rietveld 408576698