Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20987009: Rename PepperPluginDelegateImpl to PepperHelperImpl after getting rid of the PluginDelegate interfa… (Closed)

Created:
7 years, 4 months ago by jam
Modified:
7 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org
Visibility:
Public.

Description

Rename PepperPluginDelegateImpl to PepperHelperImpl after getting rid of the PluginDelegate interface. BUG=263054 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214423

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -1574 lines) Patch
M content/content_renderer.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_broker.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_broker.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/pepper/pepper_broker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_browser_connection.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_browser_connection.cc View 4 chunks +11 lines, -14 lines 0 comments Download
M content/renderer/pepper/pepper_file_io_host.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
A + content/renderer/pepper/pepper_helper_impl.h View 5 chunks +11 lines, -12 lines 0 comments Download
A + content/renderer/pepper/pepper_helper_impl.cc View 30 chunks +69 lines, -73 lines 0 comments Download
M content/renderer/pepper/pepper_platform_audio_output.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_video_capture.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_video_capture.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 chunk +0 lines, -290 lines 0 comments Download
D content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 chunk +0 lines, -852 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 16 chunks +23 lines, -24 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/plugin_module.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/ppb_broker_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/ppb_file_ref_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/ppb_image_data_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/pepper/ppb_tcp_server_socket_private_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/ppb_tcp_server_socket_private_impl.cc View 2 chunks +15 lines, -16 lines 0 comments Download
M content/renderer/pepper/ppb_tcp_socket_private_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/ppb_tcp_socket_private_impl.cc View 1 5 chunks +35 lines, -36 lines 0 comments Download
M content/renderer/pepper/ppb_video_decoder_impl.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/pepper/resource_helper.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/pepper/resource_helper.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/pepper/url_request_info_util.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A + content/renderer/pepper_helper.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + content/renderer/pepper_helper.cc View 1 chunk +14 lines, -15 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D content/renderer/render_view_pepper_helper.h View 1 chunk +0 lines, -100 lines 0 comments Download
D content/renderer/render_view_pepper_helper.cc View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
7 years, 4 months ago (2013-07-30 19:52:19 UTC) #1
jam
TBRing this move. it's not going through trybots because of the patching for some reason
7 years, 4 months ago (2013-07-30 20:12:29 UTC) #2
scottmg
7 years, 4 months ago (2013-07-30 20:18:40 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698