third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2098683003: Use enclosingIntRect when computing paint invalidations across transforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2098683003: Use enclosingIntRect when computing paint invalidations across transforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: none Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/paint/invalidation/invalidation-with-scale-transform.html ('K') | « third_party/WebKit/LayoutTests/paint/invalidation/invalidation-with-scale-transform-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 8cc5859cdb74d683fcf2beeddef15f128a77e7ba..d264acfd64dce0c00b153caf5869d1cdbf541098 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -2077,7 +2077,9 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ances

// We are now in our parent container's coordinate space. Apply our transform to obtain a bounding box

// in the parent's coordinate space that encloses us.

if (hasLayer() && layer()->transform()) {

- rect = LayoutRect(layer()->transform()->mapRect(pixelSnappedIntRect(rect)));

+ // Use enclosingIntRect because we cannot propery compute pixel snapping for painted elements within the transform since we

pdr. 2016/06/24 22:47:51 Nit propery

pdr. 2016/06/24 22:49:18 Nit: line length

chrishtr 2016/06/24 22:50:14 Done.

+ // don't know the desired subpixel accumulation at this point, and the transform may include a scale.

+ rect = LayoutRect(layer()->transform()->mapRect(enclosingIntRect(rect)));

topLeft = rect.location();

topLeft.move(locationOffset());

}