Use enclosingIntRect when computing paint invalidations across transforms

Use enclosingIntRect when computing paint invalidations across transforms.

Pixel-snapping cannot be computed correctly across the transform if the transform
includes a scale component.

BUG=622232
Committed: https://crrev.com/05953c442a6d3a9dd96bc4bb36c27f0dec5ef008
Cr-Commit-Position: refs/heads/master@{#402023}

[chrishtr, 2016-06-24 22:02:54]

Description was changed from

==========
none

BUG=
==========

to

==========
Use enclosingIntRect when computing paint invalidations across transforms.

The painting code applies pixel-snapping

BUG=
==========

[chrishtr, 2016-06-24 22:20:01]

Description was changed from

==========
Use enclosingIntRect when computing paint invalidations across transforms.

The painting code applies pixel-snapping

BUG=
==========

to

==========
Use enclosingIntRect when computing paint invalidations across transforms.

Pixel-snapping cannot be computed correctly across the transform if the
transform
includes a scale component.

BUG=622232
==========

[chrishtr, 2016-06-24 22:44:57]

chrishtr@chromium.org changed reviewers:
+ trchen@chromium.org

[pdr., 2016-06-24 22:47:50]

pdr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2016-06-24 22:47:51]

LGTM

https://codereview.chromium.org/2098683003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2098683003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2080: // Use
enclosingIntRect because we cannot propery compute pixel snapping for painted
elements within the transform since we
Nit propery

[pdr., 2016-06-24 22:48:41]

https://codereview.chromium.org/2098683003/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/paint/invalidation/invalidation-with-scale-transform.html
(right):

https://codereview.chromium.org/2098683003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/invalidation-with-scale-transform.html:5:
</div>
Nit: indentation

[pdr., 2016-06-24 22:49:19]

https://codereview.chromium.org/2098683003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2098683003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2080: // Use
enclosingIntRect because we cannot propery compute pixel snapping for painted
elements within the transform since we
Nit: line length

[chrishtr, 2016-06-24 22:50:14]

https://codereview.chromium.org/2098683003/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/paint/invalidation/invalidation-with-scale-transform.html
(right):

https://codereview.chromium.org/2098683003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/invalidation-with-scale-transform.html:5:
</div>
On 2016/06/24 at 22:48:41, pdr. wrote:
> Nit: indentation

Done.

https://codereview.chromium.org/2098683003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2098683003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2080: // Use
enclosingIntRect because we cannot propery compute pixel snapping for painted
elements within the transform since we
On 2016/06/24 at 22:47:51, pdr. wrote:
> Nit propery

Done.

[chrishtr, 2016-06-24 22:54:18]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-06-24 22:54:18]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2098683003/#ps100001
(title: "none")

[commit-bot: I haz the power, 2016-06-24 22:54:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-25 00:11:16]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-25 00:16:02]

Description was changed from

==========
Use enclosingIntRect when computing paint invalidations across transforms.

Pixel-snapping cannot be computed correctly across the transform if the
transform
includes a scale component.

BUG=622232
==========

to

==========
Use enclosingIntRect when computing paint invalidations across transforms.

Pixel-snapping cannot be computed correctly across the transform if the
transform
includes a scale component.

BUG=622232

Committed: https://crrev.com/05953c442a6d3a9dd96bc4bb36c27f0dec5ef008
Cr-Commit-Position: refs/heads/master@{#402023}
==========

[commit-bot: I haz the power, 2016-06-25 00:16:03]

Patchset 6 (id:??) landed as
https://crrev.com/05953c442a6d3a9dd96bc4bb36c27f0dec5ef008
Cr-Commit-Position: refs/heads/master@{#402023}