chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java - Issue 2098683002: Refactor OverlayPanel height calculations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java

Issue 2098683002: Refactor OverlayPanel height calculations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address donnd comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java

index 51f073c7accb4b973770a95bd75b323f9d317eb7..06a36c18ab4ca8596036945c01cb2c055224b72d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java

@@ -311,8 +311,8 @@ public class ReaderModePanel extends OverlayPanel {

}

@Override

- public void onSizeChanged(float width, float height) {

- super.onSizeChanged(width, height);

+ public void onSizeChanged(float width, float height, float visibleViewportOffsetY) {

Changwan Ryu 2016/07/07 03:29:32 onLayoutChanged?

mdjones 2016/07/07 18:33:40 Done.

+ super.onSizeChanged(width, height, visibleViewportOffsetY);

if (mManagerDelegate != null) {

mManagerDelegate.onSizeChanged();

}