Refactor OverlayPanel height calculations

chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.compositor.layouts;
 
 import static org.chromium.chrome.browser.compositor.layouts.ChromeAnimation.AnimatableAnimation.createAnimation;
 
 import android.content.Context;
 import android.graphics.Point;
@@ skipping 354 matching lines @@
      * @param availableViewport      The actual viewport this {@link Layout} should be rendering to.
      * @param visibleViewport        The visible viewport that represents the area on the screen
      *                               this {@link Layout} gets to draw to (potentially takes into
      *                               account top controls).
      * @param screenViewport         The viewport of the screen.
      * @param heightMinusTopControls The height the {@link Layout} gets excluding the height of the
      *                               top controls.  TODO(dtrainor): Look at getting rid of this.
      * @param orientation            The new orientation.  Valid values are defined by
      *                               {@link Orientation}.
      */
     public final void sizeChanged(RectF availableViewport, RectF visibleViewport,

[Changwan Ryu, 2016/07/07 03:29:32]

If availableViewport is not used any more, could you clean it up?

[mdjones, 2016/07/07 18:33:40]

Done.

             RectF screenViewport, float heightMinusTopControls, int orientation) {
-        // 1. Pull out this Layout's specific width and height properties based on the available
-        // viewport.
-        float width = availableViewport.width();

[Theresa, 2016/06/24 23:43:04]

As we discussed offline, my only concern was around whether this worked for
other places relying on this class. It turns out that the tab strip is the only
other class that uses this and it cares about the width (which should be the
same) rather than the height.

-        float height = availableViewport.height();
+        // 1. Pull out this Layout's width and height properties based on the viewport.
+        float width = screenViewport.width();
+        float height = screenViewport.height();
 
         // 2. Check if any Layout-specific properties have changed.
         boolean layoutPropertiesChanged = mWidth != width
                 || mHeight != height
                 || mHeightMinusTopControls != heightMinusTopControls
                 || mCurrentOrientation != orientation;
 
         // 3. Update the internal sizing properties.
         mWidth = width;
         mHeight = height;
         mHeightMinusTopControls = heightMinusTopControls;
         mCurrentOrientation = orientation;
 
         // 4. Notify the actual Layout if necessary.
         if (layoutPropertiesChanged) {
             notifySizeChanged(width, height, orientation);
         }
 
         // 5. TODO(dtrainor): Notify the overlay objects.
         for (int i = 0; i < mSceneOverlays.size(); i++) {
             mSceneOverlays.get(i).onSizeChanged(width, height, visibleViewport.top, orientation);

[Changwan Ryu, 2016/07/07 03:29:32]

This may slightly affect overlay panel's height in certain situations, which I
guess you already expect.

[mdjones, 2016/07/07 18:33:40]

Right, this is the expected behavior. For instance, the keyboard showing will
change the height, but we are listening for things like that.

         }
     }
 
     /**
      * Notifies when the size or the orientation of the view has actually changed.
      *
      * @param width       The new width in dp.
      * @param height      The new height in dp.
      * @param orientation The new orientation.
      */
@@ skipping 796 matching lines @@
 
     /**
      * Update {@link SceneLayer} instance this layout holds. Any class inheriting {@link Layout}
      * should override this function in order for other functions to work.
      */
     protected void updateSceneLayer(Rect viewport, Rect contentViewport,
             LayerTitleCache layerTitleCache, TabContentManager tabContentManager,
             ResourceManager resourceManager, ChromeFullscreenManager fullscreenManager) {
     }
 }