device/bluetooth/bluez: add discoverable timeout adapter property

device/bluetooth/bluez/bluetooth_bluez_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <utility>
 
@@ skipping 4144 matching lines @@
   // Calling GetConnectionInfo for a connected device should return valid
   // results.
   fake_bluetooth_device_client_->UpdateConnectionInfo(-10, 3, 4);
   BluetoothDevice::ConnectionInfo conn_info;
   device->GetConnectionInfo(base::Bind(&SaveConnectionInfo, &conn_info));
   EXPECT_EQ(-10, conn_info.rssi);
   EXPECT_EQ(3, conn_info.transmit_power);
   EXPECT_EQ(4, conn_info.max_transmit_power);
 }
 
+TEST_F(BluetoothBlueZTest, GetDiscoverableTimeout) {
+  const uint32_t kShortDiscoverableTimeout = 30;

[ortuno, 2016/06/24 20:35:53]

nit: Can you use constexpr here?

+  const uint32_t kLongDiscoverableTimeout = 240;
+  GetAdapter();
+  BluetoothAdapterBlueZ* adapter_bluez =
+      static_cast<BluetoothAdapterBlueZ*>(adapter_.get());
+
+  fake_bluetooth_adapter_client_->SetDiscoverableTimeout(
+      kShortDiscoverableTimeout);
+  EXPECT_EQ(adapter_bluez->GetDiscoverableTimeout(), kShortDiscoverableTimeout);

[ortuno, 2016/06/24 20:35:53]

Swap these two arguments. The first value should be the expected value and the
second should be the actual value. Same below.

https://cs.chromium.org/chromium/src/testing/gtest/include/gtest/gtest.h?q=EX...

+
+  fake_bluetooth_adapter_client_->SetDiscoverableTimeout(
+      kLongDiscoverableTimeout);
+  EXPECT_EQ(adapter_bluez->GetDiscoverableTimeout(), kLongDiscoverableTimeout);
+}
+
 // Verifies Shutdown shuts down the adapter as expected.
 TEST_F(BluetoothBlueZTest, Shutdown) {
   // Set up adapter. Set powered & discoverable, start discovery.
   GetAdapter();
   adapter_->SetPowered(true, GetCallback(), GetErrorCallback());
   adapter_->SetDiscoverable(true, GetCallback(), GetErrorCallback());
   adapter_->StartDiscoverySession(
       base::Bind(&BluetoothBlueZTest::DiscoverySessionCallback,
                  base::Unretained(this)),
       GetErrorCallback());
@@ skipping 306 matching lines @@
   adapter_->Shutdown();
   adapter_bluez->OnStopDiscoveryError(GetDiscoveryErrorCallback(), "", "");
 
   // 1 error reported to RemoveDiscoverySession because of OnStopDiscoveryError,
   // and kNumberOfDiscoverySessions errors queued with AddDiscoverySession.
   EXPECT_EQ(0, callback_count_);
   EXPECT_EQ(1 + kNumberOfDiscoverySessions, error_callback_count_);
 }
 
 }  // namespace bluez