Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6391)

Unified Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

Issue 2098633002: Migrate the one-time notice into the MD settings CBD dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_counters
Patch Set: Initialize to false. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
diff --git a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
index 3a2d7657477e9b1408cc6d89401c760bdf68f37a..aa11f7a2db3693769efc36f31330aa4a6c2273b7 100644
--- a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
+++ b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
@@ -66,6 +66,11 @@ class ClearBrowsingDataHandler : public SettingsPageUIHandler,
// hides the footer about other forms of history stored in user's account.
void UpdateHistoryNotice(bool show);
+ // Called as an asynchronous response to |RefreshHistoryNotice()|. Enables or
+ // disables the dialog about other forms of history stored in user's account
+ // that is shown when the history deletion is finished.
+ void UpdateHistoryDeletionDialog(bool show);
+
// Adds a browsing data |counter|.
void AddCounter(std::unique_ptr<BrowsingDataCounter> counter);
@@ -96,7 +101,11 @@ class ClearBrowsingDataHandler : public SettingsPageUIHandler,
// Whether the sentence about other forms of history stored in user's account
// should be displayed in the footer. This value is retrieved asynchronously,
// so we cache it here.
- bool should_show_history_footer_;
+ bool show_history_footer_;
+
+ // Whether we should show a dialog informing the user about other forms of
+ // history stored in their account after the history deletion is finished.
+ bool show_history_deletion_dialog_;
// A weak pointer factory for asynchronous calls referencing this class.
base::WeakPtrFactory<ClearBrowsingDataHandler> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698