Migrate the one-time notice into the MD settings CBD dialog

chrome/test/data/webui/settings/privacy_page_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings_privacy_page', function() {
   /**
    * @constructor
    * @extends {TestBrowserProxy}
    * @implements {settings.PrivacyPageBrowserProxy}
    */
@@ skipping 123 matching lines @@
               // completed.
               promiseResolver.resolve();
               // Yields to the message loop to allow the callback chain of the
               // Promise that was just resolved to execute before the
               // assertions.
             }).then(function() {
               assertFalse(element.$.dialog.opened);
               assertFalse(cancelButton.disabled);
               assertFalse(actionButton.disabled);
               assertFalse(spinner.active);
+              assertFalse(!!element.$$('#notice'));
             });
       });
 
+      test('showOtherFormsOfBrowsingHistoryNotice', function() {
+        assertTrue(element.$.dialog.opened);
+        var actionButton = element.$$('.action-button');
+        assertTrue(!!actionButton);
+
+        var promiseResolver = new PromiseResolver();
+        testBrowserProxy.setClearBrowsingDataPromise(promiseResolver.promise);
+        MockInteractions.tap(actionButton);
+
+        return testBrowserProxy.whenCalled('clearBrowsingData').then(
+            function() {
+              // Passing showNotice = true should trigger the notice about other
+              // forms of browsing history to open, and the dialog to stay open.
+              promiseResolver.resolve(true /* showNotice */);
+
+              // Yields to the message loop to allow the callback chain of the
+              // Promise that was just resolved to execute before the
+              // assertions.
+            }).then(function() {
+              // The callback should have triggered the condition to create
+              // the notice, but we must spin the message loop again until
+              // the dom-if template is notified and actually creates it.

[dschuyler, 2016/06/25 01:34:54]

Can a Polymer.dom.flush() be used rather than
spinning the update loop?

[msramek, 2016/06/27 15:24:59]

Yes! Thanks :)

+            }).then(function() {
+              var notice = element.$$('#notice');
+              assertTrue(!!notice);
+              var noticeActionButton = notice.$$('.action-button');
+              assertTrue(!!noticeActionButton);
+
+              assertTrue(element.$.dialog.opened);
+              assertTrue(notice.$.dialog.opened);
+
+              MockInteractions.tap(noticeActionButton);
+            }).then(function() {
+              var notice = element.$$('#notice');
+              assertFalse(!!notice);
+              assertFalse(element.$.dialog.opened);
+            });
+      });
+
       test('Counters', function() {
         assertTrue(element.$.dialog.opened);
 
         // Initialize the browsing history pref, which should belong to the
         // first checkbox in the dialog.
         element.set('prefs', {
           browser: {
             clear_data: {
               browsing_history: {
                 key: 'browser.clear_data.browsing_history',
@@ skipping 23 matching lines @@
 
   return {
     registerTests: function() {
       if (cr.isMac || cr.isWin)
         registerNativeCertificateManagerTests();
 
       registerClearBrowsingDataTests();
     },
   };
 });