Migrate the one-time notice into the MD settings CBD dialog

chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/sparse_histogram.h"
 #include "chrome/browser/browsing_data/autofill_counter.h"
 #include "chrome/browser/browsing_data/browsing_data_counter_utils.h"
 #include "chrome/browser/browsing_data/browsing_data_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_remover_factory.h"
 #include "chrome/browser/browsing_data/cache_counter.h"
 #include "chrome/browser/browsing_data/downloads_counter.h"
 #include "chrome/browser/browsing_data/history_counter.h"
 #include "chrome/browser/browsing_data/hosted_apps_counter.h"
 #include "chrome/browser/browsing_data/passwords_counter.h"
 #include "chrome/browser/history/web_history_service_factory.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "chrome/common/channel_info.h"
 #include "chrome/common/pref_names.h"
 #include "components/browsing_data_ui/history_notice_utils.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/web_ui.h"
 
+namespace {
+
+const int kMaxTimesHistoryNoticeShown = 1;
+
+}
+
 namespace settings {
 
 ClearBrowsingDataHandler::ClearBrowsingDataHandler(content::WebUI* webui)
     : profile_(Profile::FromWebUI(webui)),
       sync_service_(ProfileSyncServiceFactory::GetForProfile(profile_)),
       sync_service_observer_(this),
       remover_(nullptr),
       should_show_history_footer_(false),
       weak_ptr_factory_(this) {}
 
@@ skipping 120 matching lines @@
   remover_->AddObserver(this);
   remover_->Remove(
       BrowsingDataRemover::Period(
           static_cast<BrowsingDataRemover::TimePeriod>(period_selected)),
       remove_mask, origin_mask);
 }
 
 void ClearBrowsingDataHandler::OnBrowsingDataRemoverDone() {
   remover_->RemoveObserver(this);
   remover_ = nullptr;
+
+  PrefService* prefs = profile_->GetPrefs();
+  int notice_shown_times =
+      prefs->GetInteger(prefs::kClearBrowsingDataHistoryNoticeShownTimes);
+
+  // When the deletion is complete, we might show an additional dialog with
+  // a notice about other forms of browsing history. This is the case if
+  const bool show_notice =
+      // 1. The dialog is relevant for the user.
+      should_show_history_deletion_dialog_ &&
+      // 2. The selected data types contained browsing history.
+      prefs->GetBoolean(prefs::kDeleteBrowsingHistory) &&
+      // 3. The notice has been shown less than |kMaxTimesHistoryNoticeShown|.
+      notice_shown_times < kMaxTimesHistoryNoticeShown;

[dschuyler, 2016/06/25 01:34:54]

nit: not a big deal, but if #2 and #3 were swapped,
we may avoid calling prefs-GetBoolean when
notice_shown_times < kMaxTimesHistoryNoticeShown
is false.

[msramek, 2016/06/27 15:24:59]

Done.

+
+  if (show_notice) {
+    // Increment the preference.
+    prefs->SetInteger(prefs::kClearBrowsingDataHistoryNoticeShownTimes,
+                      notice_shown_times + 1);

[dschuyler, 2016/06/25 01:34:54]

trivia: it looks like there is a potential race
condition here. It also looks like the effect of
that race are harmless. This note is just to ask
that it be given consideration (whether the race
is an issue). If (as I expect) it's harmless, then
an 'ack' on this note is plenty.

[msramek, 2016/06/27 15:24:59]

Acknowledged. Thanks for pointing it out.

+  }
+
+  UMA_HISTOGRAM_BOOLEAN(
+      "History.ClearBrowsingData.ShownHistoryNoticeAfterClearing", show_notice);
+
   ResolveJavascriptCallback(
       base::StringValue(webui_callback_id_),
-      *base::Value::CreateNullValue());
+      base::FundamentalValue(show_notice));
   webui_callback_id_.clear();
 }
 
 void ClearBrowsingDataHandler::OnBrowsingHistoryPrefChanged() {
   CallJavascriptFunction(
       "cr.webUIListenerCallback",
       base::StringValue("browsing-history-pref-changed"),
       base::FundamentalValue(
           profile_->GetPrefs()->GetBoolean(
               prefs::kAllowDeletingBrowserHistory)));
@@ skipping 21 matching lines @@
       base::FundamentalValue(sync_service_ && sync_service_->IsSyncActive()),
       base::FundamentalValue(should_show_history_footer_));
 }
 
 void ClearBrowsingDataHandler::RefreshHistoryNotice() {
   browsing_data_ui::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
       sync_service_,
       WebHistoryServiceFactory::GetForProfile(profile_),
       base::Bind(&ClearBrowsingDataHandler::UpdateHistoryNotice,
                  weak_ptr_factory_.GetWeakPtr()));
+
+  // If the dialog with history notice has been shown less than
+  // |kMaxTimesHistoryNoticeShown| times, we might have to show it when the
+  // user deletes history. Find out if the conditions are met.
+  int notice_shown_times = profile_->GetPrefs()->
+      GetInteger(prefs::kClearBrowsingDataHistoryNoticeShownTimes);
+
+  if (notice_shown_times < kMaxTimesHistoryNoticeShown) {
+    browsing_data_ui::ShouldPopupDialogAboutOtherFormsOfBrowsingHistory(
+        sync_service_,
+        WebHistoryServiceFactory::GetForProfile(profile_),
+        chrome::GetChannel(),
+        base::Bind(&ClearBrowsingDataHandler::UpdateHistoryDeletionDialog,
+                   weak_ptr_factory_.GetWeakPtr()));
+  }
 }
 
 void ClearBrowsingDataHandler::UpdateHistoryNotice(bool show) {
   should_show_history_footer_ = show;
   OnStateChanged();
 
   UMA_HISTOGRAM_BOOLEAN(
       "History.ClearBrowsingData.HistoryNoticeShownInFooterWhenUpdated",
       should_show_history_footer_);
 }
 
+void ClearBrowsingDataHandler::UpdateHistoryDeletionDialog(bool show) {
+  // This is used by OnBrowsingDataRemoverDone (when the deletion finishes).
+  should_show_history_deletion_dialog_ = show;
+}
+
 void ClearBrowsingDataHandler::AddCounter(
     std::unique_ptr<BrowsingDataCounter> counter) {
   counter->Init(
       profile_,
       base::Bind(&ClearBrowsingDataHandler::UpdateCounterText,
                  base::Unretained(this)));
   counter->Restart();
   counters_.push_back(std::move(counter));
 }
 
 void ClearBrowsingDataHandler::UpdateCounterText(
     std::unique_ptr<BrowsingDataCounter::Result> result) {
   CallJavascriptFunction(
       "cr.webUIListenerCallback",
       base::StringValue("update-counter-text"),
       base::StringValue(result->source()->GetPrefName()),
       base::StringValue(GetCounterTextFromResult(result.get())));
 }
 
 }  // namespace settings