Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 209863004: PreParser cleanup: no need to track with-ness of scopes. (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

PreParser cleanup: no need to track with-ness of scopes. Historically, we used to track the "with-ness" of a scope differently; not creating a with scope, but setting a property on the scope (see https://codereview.chromium.org/5166006 ). For laziness decisions, checking the with-ness should be unnecessary: the current scope is function scope, and if the outer scope is global scope, there's surely no with scope in between. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20189

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M src/preparser.h View 2 chunks +1 line, -13 lines 0 comments Download
M src/preparser.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
ulan, ptal
6 years, 9 months ago (2014-03-24 11:44:40 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-24 11:50:02 UTC) #2
marja
6 years, 9 months ago (2014-03-24 12:16:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698