Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2098613005: Enable thread_times benchmarks on Windows (Closed)

Created:
4 years, 6 months ago by sullivan
Modified:
4 years, 5 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable thread_times benchmarks on Windows BUG=443781, 568175 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/a8531dcdee790985eb8f87daa9256c5c907b141f Cr-Commit-Position: refs/heads/master@{#403174}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove stray extra line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/benchmarks/thread_times.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
sullivan
4 years, 6 months ago (2016-06-24 21:07:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098613005/1
4 years, 6 months ago (2016-06-24 21:07:18 UTC) #5
nednguyen
lgtm https://codereview.chromium.org/2098613005/diff/1/tools/perf/docs/perf_bot_sheriffing.md File tools/perf/docs/perf_bot_sheriffing.md (right): https://codereview.chromium.org/2098613005/diff/1/tools/perf/docs/perf_bot_sheriffing.md#newcode255 tools/perf/docs/perf_bot_sheriffing.md:255: is this change intentional?
4 years, 6 months ago (2016-06-24 21:08:19 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098613005/20001
4 years, 5 months ago (2016-06-27 03:28:11 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-06-27 08:02:38 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098613005/20001
4 years, 5 months ago (2016-06-30 04:38:11 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/29334)
4 years, 5 months ago (2016-06-30 06:06:48 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098613005/20001
4 years, 5 months ago (2016-06-30 12:29:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098613005/20001
4 years, 5 months ago (2016-06-30 14:44:33 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 14:48:19 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 14:48:27 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 14:51:14 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8531dcdee790985eb8f87daa9256c5c907b141f
Cr-Commit-Position: refs/heads/master@{#403174}

Powered by Google App Engine
This is Rietveld 408576698