Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2098613003: [Mac/GN] Use -gdwarf-2 instead of -g2 in //build/config/compiler:symbols. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Use -gdwarf-2 instead of -g2 in //build/config/compiler:symbols. This matches GYP. BUG=622889, 622406 R=dpranke@chromium.org Committed: https://crrev.com/adfae52965b56ca7a17fbd60149f78be801691f1 Cr-Commit-Position: refs/heads/master@{#401781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Robert Sesek
We can try flipping the official bot again after this.
4 years, 6 months ago (2016-06-23 23:02:07 UTC) #1
Dirk Pranke
lgtm. sounds good ...
4 years, 6 months ago (2016-06-23 23:14:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098613003/1
4 years, 6 months ago (2016-06-23 23:35:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 01:56:51 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 01:58:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adfae52965b56ca7a17fbd60149f78be801691f1
Cr-Commit-Position: refs/heads/master@{#401781}

Powered by Google App Engine
This is Rietveld 408576698