Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: LayoutTests/fast/events/constructors/keyboard-event-constructor.html

Issue 20986003: Define DOM_KEY_LOCATION_* constants on KeyboardEvent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/events/constructors/keyboard-event-constructor.html
diff --git a/LayoutTests/fast/events/constructors/keyboard-event-constructor.html b/LayoutTests/fast/events/constructors/keyboard-event-constructor.html
index db0bccb98e328d67429a3650554dfd61400263ba..665fdd29b1f41094ec7909a48a09c40ddba5cd70 100644
--- a/LayoutTests/fast/events/constructors/keyboard-event-constructor.html
+++ b/LayoutTests/fast/events/constructors/keyboard-event-constructor.html
@@ -72,8 +72,8 @@ shouldBeEqualToString("new KeyboardEvent('eventType', { keyIdentifier: {valueOf:
// keyLocation is passed.
// numbers within the unsigned long range.
-shouldBe("new KeyboardEvent('eventType', { keyLocation: 0 }).keyLocation", "0");
-shouldBe("new KeyboardEvent('eventType', { keyLocation: 1 }).keyLocation", "1");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: KeyboardEvent.DOM_KEY_LOCATION_STANDARD }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: KeyboardEvent.DOM_KEY_LOCATION_LEFT }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_LEFT");
shouldBe("new KeyboardEvent('eventType', { keyLocation: 4294967294 }).keyLocation", "4294967294");
shouldBe("new KeyboardEvent('eventType', { keyLocation: 4294967295 }).keyLocation", "4294967295");
@@ -81,24 +81,24 @@ shouldBe("new KeyboardEvent('eventType', { keyLocation: 4294967295 }).keyLocatio
// 2^{53}-1, the largest number that can be exactly represented by double.
shouldBe("new KeyboardEvent('eventType', { keyLocation: 9007199254740991 }).keyLocation", "4294967295");
// 2^{64}-1
-shouldBe("new KeyboardEvent('eventType', { keyLocation: 18446744073709551615 }).keyLocation", "0");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: 18446744073709551615 }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
shouldBe("new KeyboardEvent('eventType', { keyLocation: 12345678901234567890 }).keyLocation", "3944679424");
shouldBe("new KeyboardEvent('eventType', { keyLocation: -1 }).keyLocation", "4294967295");
shouldBe("new KeyboardEvent('eventType', { keyLocation: 123.45 }).keyLocation", "123");
-shouldBe("new KeyboardEvent('eventType', { keyLocation: NaN }).keyLocation", "0");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: NaN }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
// Non-numeric values.
-shouldBe("new KeyboardEvent('eventType', { keyLocation: undefined }).keyLocation", "0");
-shouldBe("new KeyboardEvent('eventType', { keyLocation: null }).keyLocation", "0");
-shouldBe("new KeyboardEvent('eventType', { keyLocation: '' }).keyLocation", "0");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: undefined }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: null }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: '' }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
shouldBe("new KeyboardEvent('eventType', { keyLocation: '12345' }).keyLocation", "12345");
-shouldBe("new KeyboardEvent('eventType', { keyLocation: '12345a' }).keyLocation", "0");
-shouldBe("new KeyboardEvent('eventType', { keyLocation: 'abc' }).keyLocation", "0");
-shouldBe("new KeyboardEvent('eventType', { keyLocation: [] }).keyLocation", "0");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: '12345a' }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: 'abc' }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: [] }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
shouldBe("new KeyboardEvent('eventType', { keyLocation: [12345] }).keyLocation", "12345");
-shouldBe("new KeyboardEvent('eventType', { keyLocation: [12345, 67890] }).keyLocation", "0");
-shouldBe("new KeyboardEvent('eventType', { keyLocation: {} }).keyLocation", "0");
-shouldBe("new KeyboardEvent('eventType', { keyLocation: {moemoe: 12345} }).keyLocation", "0");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: [12345, 67890] }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: {} }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
+shouldBe("new KeyboardEvent('eventType', { keyLocation: {moemoe: 12345} }).keyLocation", "KeyboardEvent.DOM_KEY_LOCATION_STANDARD");
shouldBe("new KeyboardEvent('eventType', { keyLocation: {valueOf: function () { return 12345; }} }).keyLocation", "12345");
// ctrlKey, altKey, shiftKey and metaKey are passed.

Powered by Google App Engine
This is Rietveld 408576698