tests/ColorSpaceTest.cpp - Issue 2098583002: SkMatrix44 clarifications and clean-ups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/ColorSpaceTest.cpp

Issue 2098583002: SkMatrix44 clarifications and clean-ups (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/ColorSpaceTest.cpp

diff --git a/tests/ColorSpaceTest.cpp b/tests/ColorSpaceTest.cpp

index 853bdceb4f88dbd6ef397d0b57031fa0a665814a..442ed3df30cf370246a5fd502eca950e579e7cff 100644

--- a/tests/ColorSpaceTest.cpp

+++ b/tests/ColorSpaceTest.cpp

@@ -101,7 +101,7 @@ DEF_TEST(ColorSpaceSRGBCompare, r) {

// Create an sRGB color space by value

SkMatrix44 srgbToxyzD50(SkMatrix44::kUninitialized_Constructor);

- srgbToxyzD50.set3x3ColMajorf(g_sRGB_XYZ);

+ srgbToxyzD50.set3x3RowMajorf(g_sRGB_XYZ);

sk_sp<SkColorSpace> rgbColorSpace = SkColorSpace::NewRGB(SkColorSpace::kSRGB_GammaNamed,

srgbToxyzD50);

REPORTER_ASSERT(r, rgbColorSpace == namedColorSpace);

« no previous file with comments | « src/core/SkMatrix44.cpp ('k') | tests/Matrix44Test.cpp » ('j') | no next file with comments »