Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 2098573004: DBC: CheckClassInstr (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Trying to find static call deopt bug Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index cc5e51f9a91bec5a4dcc6b578d255df57b05aa9d..c2de24c15778367b6cc440b6a7608243c74f5a51 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -3329,13 +3329,15 @@ void StaticCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ PushConstant(function());
__ StaticCall(ArgumentCount(), argdesc_kidx);
- compiler->AddCurrentDescriptor(RawPcDescriptors::kUnoptStaticCall,
- deopt_id(),
- token_pos());
+ RawPcDescriptors::Kind kind = (compiler->is_optimizing())
zra 2016/06/24 22:37:49 Fixing this doesn't stop the assert from being hit
+ ? RawPcDescriptors::kOther
+ : RawPcDescriptors::kUnoptStaticCall;
+ compiler->AddCurrentDescriptor(kind, deopt_id(), token_pos());
compiler->RecordAfterCall(this);
if (compiler->is_optimizing()) {
+ compiler->AddStaticCallTarget(function());
__ PopLocal(locs()->out(0).reg());
}
#endif // !defined(TARGET_ARCH_DBC)

Powered by Google App Engine
This is Rietveld 408576698