content/content_browser.gypi - Issue 2098553002: Geolocation: extract ContentBrowserClient methods specific to Geolocation into a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/content_browser.gypi

Issue 2098553002: Geolocation: extract ContentBrowserClient methods specific to Geolocation into a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changing to ContentBrowserClient::GetGeolocationServiceOverrides and impl'd in the 6 impl's. Unitte… Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/geolocation/location_arbitrator_impl_unittest.cc ('K') | « content/browser/geolocation/location_arbitrator_impl_unittest.cc ('k') | content/public/browser/content_browser_client.h » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/content_browser.gypi

diff --git a/content/content_browser.gypi b/content/content_browser.gypi

index 5ed470c9f9974da4dddb6f08aa48bc1ead8e4fc2..2a6566658dd1be6e5f4161cebf61f774cd2ae5aa 100644

--- a/content/content_browser.gypi

+++ b/content/content_browser.gypi

@@ -189,6 +189,7 @@

'public/browser/file_descriptor_info.h',

'public/browser/focused_node_details.h',

'public/browser/font_list_async.h',

+ 'public/browser/geolocation_provider.cc',

Michael van Ouwerkerk 2016/06/24 13:57:19 Is this file suitable for the public content api?

mcasas 2016/06/24 19:25:52 Please see my reply to your comment in the file it

'public/browser/geolocation_provider.h',

'public/browser/global_request_id.h',

'public/browser/gpu_data_manager.h',