Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4370)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2098553002: Geolocation: extract ContentBrowserClient methods specific to Geolocation into a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Minor touch in LocationArbitratorImplTest to restate previous behaviour. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index cce6055d14114802396ae3cbd025d6e14eba2cb0..0d7358cb597b359f8161aa983113f5db68bf1a48 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -627,6 +627,15 @@ class SafeBrowsingSSLCertReporter : public SSLCertReporter {
safe_browsing_ui_manager_;
};
+// A provider of Geolocation services to override AccessTokenStore.
+class ChromeGeolocationDelegate
Michael van Ouwerkerk 2016/06/28 11:17:07 nit: DISALLOW_COPY_AND_ASSIGN
mcasas 2016/06/28 16:51:25 Done.
+ : public content::GeolocationProvider::Delegate {
+ public:
+ AccessTokenStore* CreateAccessTokenStore() final {
+ return new ChromeAccessTokenStore();
+ }
+};
+
#if BUILDFLAG(ANDROID_JAVA_UI)
void HandleSingleTabModeBlockOnUIThread(const BlockedWindowParams& params) {
WebContents* web_contents = tab_util::GetWebContentsByFrameID(
@@ -2245,8 +2254,9 @@ net::NetLog* ChromeContentBrowserClient::GetNetLog() {
return g_browser_process->net_log();
}
-AccessTokenStore* ChromeContentBrowserClient::CreateAccessTokenStore() {
- return new ChromeAccessTokenStore();
+content::GeolocationProvider::Delegate*
+ChromeContentBrowserClient::CreateGeolocationDelegate() {
+ return new ChromeGeolocationDelegate();
}
bool ChromeContentBrowserClient::IsFastShutdownPossible() {

Powered by Google App Engine
This is Rietveld 408576698