Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: content/public/browser/content_browser_client.cc

Issue 2098553002: Geolocation: extract ContentBrowserClient methods specific to Geolocation into a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/browser/content_browser_client.h" 5 #include "content/public/browser/content_browser_client.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/guid.h" 8 #include "base/guid.h"
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "content/public/browser/client_certificate_delegate.h" 10 #include "content/public/browser/client_certificate_delegate.h"
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 300
301 SpeechRecognitionManagerDelegate* 301 SpeechRecognitionManagerDelegate*
302 ContentBrowserClient::CreateSpeechRecognitionManagerDelegate() { 302 ContentBrowserClient::CreateSpeechRecognitionManagerDelegate() {
303 return nullptr; 303 return nullptr;
304 } 304 }
305 305
306 net::NetLog* ContentBrowserClient::GetNetLog() { 306 net::NetLog* ContentBrowserClient::GetNetLog() {
307 return nullptr; 307 return nullptr;
308 } 308 }
309 309
310 AccessTokenStore* ContentBrowserClient::CreateAccessTokenStore() { 310 GeolocationProvider::Delegate*
311 ContentBrowserClient::CreateGeolocationDelegate() {
312 // We don't need to override anything, the default implementation is good.
311 return nullptr; 313 return nullptr;
312 } 314 }
313 315
314 bool ContentBrowserClient::IsFastShutdownPossible() { 316 bool ContentBrowserClient::IsFastShutdownPossible() {
315 return true; 317 return true;
316 } 318 }
317 319
318 base::FilePath ContentBrowserClient::GetDefaultDownloadDirectory() { 320 base::FilePath ContentBrowserClient::GetDefaultDownloadDirectory() {
319 return base::FilePath(); 321 return base::FilePath();
320 } 322 }
(...skipping 28 matching lines...) Expand all
349 std::unique_ptr<VpnServiceProxy> ContentBrowserClient::GetVpnServiceProxy( 351 std::unique_ptr<VpnServiceProxy> ContentBrowserClient::GetVpnServiceProxy(
350 BrowserContext* browser_context) { 352 BrowserContext* browser_context) {
351 return nullptr; 353 return nullptr;
352 } 354 }
353 355
354 ui::SelectFilePolicy* ContentBrowserClient::CreateSelectFilePolicy( 356 ui::SelectFilePolicy* ContentBrowserClient::CreateSelectFilePolicy(
355 WebContents* web_contents) { 357 WebContents* web_contents) {
356 return nullptr; 358 return nullptr;
357 } 359 }
358 360
359 LocationProvider* ContentBrowserClient::OverrideSystemLocationProvider() {
360 return nullptr;
361 }
362
363 bool ContentBrowserClient::UseNetworkLocationProviders() {
364 return true;
365 }
366
367 DevToolsManagerDelegate* ContentBrowserClient::GetDevToolsManagerDelegate() { 361 DevToolsManagerDelegate* ContentBrowserClient::GetDevToolsManagerDelegate() {
368 return nullptr; 362 return nullptr;
369 } 363 }
370 364
371 TracingDelegate* ContentBrowserClient::GetTracingDelegate() { 365 TracingDelegate* ContentBrowserClient::GetTracingDelegate() {
372 return nullptr; 366 return nullptr;
373 } 367 }
374 368
375 bool ContentBrowserClient::IsPluginAllowedToCallRequestOSFileHandle( 369 bool ContentBrowserClient::IsPluginAllowedToCallRequestOSFileHandle(
376 BrowserContext* browser_context, 370 BrowserContext* browser_context,
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 #if defined(VIDEO_HOLE) 432 #if defined(VIDEO_HOLE)
439 ExternalVideoSurfaceContainer* 433 ExternalVideoSurfaceContainer*
440 ContentBrowserClient::OverrideCreateExternalVideoSurfaceContainer( 434 ContentBrowserClient::OverrideCreateExternalVideoSurfaceContainer(
441 WebContents* web_contents) { 435 WebContents* web_contents) {
442 NOTREACHED() << "Hole-punching is not supported. See crbug.com/469348."; 436 NOTREACHED() << "Hole-punching is not supported. See crbug.com/469348.";
443 return nullptr; 437 return nullptr;
444 } 438 }
445 #endif 439 #endif
446 440
447 } // namespace content 441 } // namespace content
OLDNEW
« no previous file with comments | « content/public/browser/content_browser_client.h ('k') | content/public/browser/geolocation_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698