PlzNavigate: Handle navigation within MHTML documents

PlzNavigate: Handle navigation within MHTML documents

Within MHTML documents, the content ID scheme ("cid:") is used to specify
navigations to another part of the document. Blink understands how to load
such resources (cf. MHTMLArchive.cpp and ResourceFetcher.cpp), so //content
doesn't need to anything special for them. In particular, it does not need
to make a network request when navigating to such URLs. This CL adds that
behavior so that PlzNavigate correctly handles such navigations.

BUG=623553
Committed: https://crrev.com/000b07903ead3a349dc6a786c843cdf57900f143
Cr-Commit-Position: refs/heads/master@{#402438}

[Mike West, 2016-06-24 09:08:32]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2016-06-24 09:08:32]

This LGTM % tests, FWIW. Is there a bug to which you can link this and
https://codereview.chromium.org/2098723003?

https://codereview.chromium.org/2098543003/diff/1/content/common/navigation_p...
File content/common/navigation_params.cc (right):

https://codereview.chromium.org/2098543003/diff/1/content/common/navigation_p...
content/common/navigation_params.cc:18: bool
ShouldMakeNetworkRequestForURL(const GURL& url) {
Would you mind adding a unit test for this method?

[blundell, 2016-06-27 13:31:30]

Description was changed from

==========
PlzNavigate: Handle navigation within MHTML documents

Within MHTML documents, the content ID scheme ("cid:") is used to specify
navigations to another part of the document. Blink understands how to load
such resources (cf. MHTMLArchive.cpp and ResourceFetcher.cpp), so //content
doesn't need to anything special for them. In particular, it does not need
to make a network request when navigating to such URLs. This CL adds that
behavior so that PlzNavigate correctly handles such navigations.
==========

to

==========
PlzNavigate: Handle navigation within MHTML documents

Within MHTML documents, the content ID scheme ("cid:") is used to specify
navigations to another part of the document. Blink understands how to load
such resources (cf. MHTMLArchive.cpp and ResourceFetcher.cpp), so //content
doesn't need to anything special for them. In particular, it does not need
to make a network request when navigating to such URLs. This CL adds that
behavior so that PlzNavigate correctly handles such navigations.

BUG=623553
==========

[blundell, 2016-06-27 14:00:58]

blundell@chromium.org changed reviewers:
+ clamy@chromium.org

[blundell, 2016-06-27 14:00:58]

Thanks!

+clamy@

https://codereview.chromium.org/2098543003/diff/1/content/common/navigation_p...
File content/common/navigation_params.cc (right):

https://codereview.chromium.org/2098543003/diff/1/content/common/navigation_p...
content/common/navigation_params.cc:18: bool
ShouldMakeNetworkRequestForURL(const GURL& url) {
On 2016/06/24 09:08:32, Mike West wrote:
> Would you mind adding a unit test for this method?

Done.

[clamy, 2016-06-27 14:09:16]

Thanks! And nice that we have tests for the method noe! lgtm.

[blundell, 2016-06-28 08:23:30]

The CQ bit was checked by blundell@chromium.org

[blundell, 2016-06-28 08:23:30]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
clamy@chromium.org
Link to the patchset: https://codereview.chromium.org/2098543003/#ps60001
(title: "Make component build work")

[commit-bot: I haz the power, 2016-06-28 08:23:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 10:33:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-28 10:34:50]

Description was changed from

==========
PlzNavigate: Handle navigation within MHTML documents

Within MHTML documents, the content ID scheme ("cid:") is used to specify
navigations to another part of the document. Blink understands how to load
such resources (cf. MHTMLArchive.cpp and ResourceFetcher.cpp), so //content
doesn't need to anything special for them. In particular, it does not need
to make a network request when navigating to such URLs. This CL adds that
behavior so that PlzNavigate correctly handles such navigations.

BUG=623553
==========

to

==========
PlzNavigate: Handle navigation within MHTML documents

Within MHTML documents, the content ID scheme ("cid:") is used to specify
navigations to another part of the document. Blink understands how to load
such resources (cf. MHTMLArchive.cpp and ResourceFetcher.cpp), so //content
doesn't need to anything special for them. In particular, it does not need
to make a network request when navigating to such URLs. This CL adds that
behavior so that PlzNavigate correctly handles such navigations.

BUG=623553

Committed: https://crrev.com/000b07903ead3a349dc6a786c843cdf57900f143
Cr-Commit-Position: refs/heads/master@{#402438}
==========

[commit-bot: I haz the power, 2016-06-28 10:34:51]

Patchset 4 (id:??) landed as
https://crrev.com/000b07903ead3a349dc6a786c843cdf57900f143
Cr-Commit-Position: refs/heads/master@{#402438}