Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: Source/bindings/v8/ScriptPromiseTest.cpp

Issue 209853010: [ABANDONED] Enable V8 Promises (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptPromiseResolverWithContext.cpp ('k') | Source/bindings/v8/V8Initializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptPromiseTest.cpp
diff --git a/Source/bindings/v8/ScriptPromiseTest.cpp b/Source/bindings/v8/ScriptPromiseTest.cpp
index c25b6cd93f0ee19ea9c748ad56284e673a7d4b21..c30fc3e13f5595de2937944e66476e720cb9623b 100644
--- a/Source/bindings/v8/ScriptPromiseTest.cpp
+++ b/Source/bindings/v8/ScriptPromiseTest.cpp
@@ -31,6 +31,7 @@
#include "config.h"
#include "bindings/v8/ScriptPromise.h"
+#include "RuntimeEnabledFeatures.h"
#include "bindings/v8/DOMWrapperWorld.h"
#include "bindings/v8/ScriptPromiseResolver.h"
#include "bindings/v8/ScriptValue.h"
@@ -82,6 +83,8 @@ TEST_F(ScriptPromiseTest, constructFromNonPromise)
TEST_F(ScriptPromiseTest, castPromise)
{
+ if (RuntimeEnabledFeatures::scriptPromiseOnV8PromiseEnabled())
+ return;
ScriptPromise promise = ScriptPromiseResolver::create(m_isolate)->promise();
ScriptPromise newPromise = ScriptPromise::cast(ScriptValue(promise.v8Value(), m_isolate));
@@ -92,6 +95,8 @@ TEST_F(ScriptPromiseTest, castPromise)
TEST_F(ScriptPromiseTest, castNonPromise)
{
+ if (RuntimeEnabledFeatures::scriptPromiseOnV8PromiseEnabled())
+ return;
ScriptValue value = ScriptValue(v8String(m_isolate, "hello"), m_isolate);
ScriptPromise promise1 = ScriptPromise::cast(ScriptValue(value.v8Value(), m_isolate));
ScriptPromise promise2 = ScriptPromise::cast(ScriptValue(value.v8Value(), m_isolate));
« no previous file with comments | « Source/bindings/v8/ScriptPromiseResolverWithContext.cpp ('k') | Source/bindings/v8/V8Initializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698