Source/bindings/v8/V8Initializer.cpp - Issue 209853010: [ABANDONED] Enable V8 Promises

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Initializer.cpp

Issue 209853010: [ABANDONED] Enable V8 Promises (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/ScriptPromiseResolverWithContext.cpp ('K') | « Source/bindings/v8/ScriptPromiseTest.cpp ('k') | Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/V8Initializer.cpp

diff --git a/Source/bindings/v8/V8Initializer.cpp b/Source/bindings/v8/V8Initializer.cpp

index 37ca57dfeae7290a2b9cda2a92c2ece482740128..21f7d523d4b9caceba12e0801db61affd5e5b32d 100644

--- a/Source/bindings/v8/V8Initializer.cpp

+++ b/Source/bindings/v8/V8Initializer.cpp

@@ -166,12 +166,15 @@ static void timerTraceProfilerInMainThread(const char* name, int status)

static void initializeV8Common(v8::Isolate* isolate)

{

+ // FIXME: This is a temporary flags and should be removed soon.

+ const char promiseFlags[] = "--harmony-promises";

v8::ResourceConstraints constraints;

constraints.ConfigureDefaults(static_cast<uint64_t>(blink::Platform::current()->physicalMemoryMB()) << 20, static_cast<uint32_t>(blink::Platform::current()->virtualMemoryLimitMB()) << 20, static_cast<uint32_t>(blink::Platform::current()->numberOfProcessors()));

v8::SetResourceConstraints(isolate, &constraints);

v8::V8::AddGCPrologueCallback(V8GCController::gcPrologue);

v8::V8::AddGCEpilogueCallback(V8GCController::gcEpilogue);

+ v8::V8::SetFlagsFromString(promiseFlags, strlen(promiseFlags));

v8::Debug::SetLiveEditEnabled(false);

}