[ABANDONED] Enable V8 Promises

Source/bindings/v8/ScriptPromiseResolverWithContext.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ScriptPromiseResolverWithContext_h
 #define ScriptPromiseResolverWithContext_h
 
 #include "bindings/v8/NewScriptState.h"
 #include "bindings/v8/ScopedPersistent.h"
 #include "bindings/v8/ScriptPromise.h"
@@ skipping 23 matching lines @@
     static PassRefPtr<ScriptPromiseResolverWithContext> create(NewScriptState* scriptState)
     {
         RefPtr<ScriptPromiseResolverWithContext> resolver = adoptRef(new ScriptPromiseResolverWithContext(scriptState));
         resolver->suspendIfNeeded();
         return resolver.release();
     }
 
     template <typename T>
     void resolve(T value)
     {
-        if (m_state != Pending || !executionContext() || executionContext()->activeDOMObjectsAreStopped())
-            return;
-        m_state = Resolving;
-        NewScriptState::Scope scope(m_scriptState.get());
-        m_value.set(m_scriptState->isolate(), toV8(value));
-        if (!executionContext()->activeDOMObjectsAreSuspended())
-            resolveOrRejectImmediately(&m_timer);
+        resolveOrReject(value, Resolving);
     }
 
     template <typename T>
     void reject(T value)
     {
-        if (m_state != Pending || !executionContext() || executionContext()->activeDOMObjectsAreStopped())
-            return;
-        m_state = Rejecting;
-        NewScriptState::Scope scope(m_scriptState.get());
-        m_value.set(m_scriptState->isolate(), toV8(value));
-        if (!executionContext()->activeDOMObjectsAreSuspended())
-            resolveOrRejectImmediately(&m_timer);
+        resolveOrReject(value, Rejecting);
     }
 
     // Note that an empty ScriptPromise will be returned after resolve or
     // reject is called.
     ScriptPromise promise()
     {
         return m_resolver ? m_resolver->promise() : ScriptPromise();
     }
 
     // ActiveDOMObject implementation.
@@ skipping 19 matching lines @@
         return toV8NoInline(value, m_scriptState->context()->Global(), m_scriptState->isolate());
     }
     template <typename T> v8::Handle<v8::Value> toV8(PassRefPtr<T> value) { return toV8(value.get()); }
     template <typename T> v8::Handle<v8::Value> toV8(RawPtr<T> value) { return toV8(value.get()); }
     template <typename T, size_t inlineCapacity>
     v8::Handle<v8::Value> toV8(const Vector<T, inlineCapacity>& value)
     {
         ASSERT(m_scriptState);
         return v8ArrayNoInline(value, m_scriptState->isolate());
     }
-    v8::Handle<v8::Value> toV8(ScriptValue value)
+    v8::Handle<v8::Value> toV8(ScriptValue value) { return value.v8Value(); }
+    v8::Handle<v8::Value> toV8(v8::Handle<v8::Value> value) { return value; }
+
+    template <typename T>
+    void resolveOrReject(T value, ResolutionState newState)
     {
-        return value.v8Value();
+        if (m_state != Pending || !executionContext() || executionContext()->activeDOMObjectsAreStopped())
+            return;
+        m_state = newState;
+        // Retain this object until it is actually resolved or rejected.
+        // deref will be called in resolveOrRejectImmediately.
+        ref();

[yhirano, 2014/04/15 08:45:06]

I don't like the manual ref counting, but I couldn't think of a better solution.

+
+        bool isInContext = m_scriptState->isolate()->InContext();
+        NewScriptState::Scope scope(m_scriptState.get());
+        m_value.set(m_scriptState->isolate(), toV8(value));
+        if (!executionContext()->activeDOMObjectsAreSuspended()) {
+            if (isInContext) {
+                resolveOrRejectImmediately();
+            } else {
+                m_timer.startOneShot(0, FROM_HERE);
+            }
+        }
     }
 
-    void resolveOrRejectImmediately(Timer<ScriptPromiseResolverWithContext>*);
+    void resolveOrRejectImmediately();
+    void onTimerFired(Timer<ScriptPromiseResolverWithContext>*);
     void clear();
 
     ResolutionState m_state;
     RefPtr<NewScriptState> m_scriptState;
     Timer<ScriptPromiseResolverWithContext> m_timer;
     RefPtr<ScriptPromiseResolver> m_resolver;
     ScopedPersistent<v8::Value> m_value;
 };
 
 } // namespace WebCore
 
 #endif // #ifndef ScriptPromiseResolverWithContext_h