[ABANDONED] Enable V8 Promises

Source/core/workers/WorkerRunLoop.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/workers/WorkerRunLoop.h"
 
+#include "bindings/v8/V8RecursionScope.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/workers/WorkerGlobalScope.h"
 #include "core/workers/WorkerThread.h"
 #include "heap/ThreadState.h"
 #include "platform/PlatformThreadData.h"
 #include "platform/SharedTimer.h"
 #include "platform/ThreadTimers.h"
 #include "wtf/CurrentTime.h"
 
 namespace WebCore {
 
 class WorkerRunLoopTask : public blink::WebThread::Task {
     WTF_MAKE_NONCOPYABLE(WorkerRunLoopTask); WTF_MAKE_FAST_ALLOCATED;
 public:
     static PassOwnPtr<WorkerRunLoopTask> create(const WorkerRunLoop& runLoop, PassOwnPtr<ExecutionContextTask> task)
     {
         return adoptPtr(new WorkerRunLoopTask(runLoop, task));
     }
 
     virtual ~WorkerRunLoopTask() { }
 
     virtual void run() OVERRIDE
     {
         WorkerGlobalScope* workerGlobalScope = m_runLoop.context();
-        if ((!workerGlobalScope->isClosing() && !m_runLoop.terminated()) || m_task->isCleanupTask())
+        if ((!workerGlobalScope->isClosing() && !m_runLoop.terminated()) || m_task->isCleanupTask()) {
+            V8RecursionScope recursionScope(workerGlobalScope);

[adamk, 2014/03/28 17:55:05]

This seems like the wrong place to put this, V8RecursionScope is about script
execution, not general task running. Also, by wrapping the entire performTask
call, if the task dispatches events to multiple listeners, we'll get the wrong
end-of-microtask semantics (each event dispatch should end in performCheckpoint,
not just one for the whole task).

And it feels like layer violation for WorkerRunLoop to know about
V8RecursionScope.

             m_task->performTask(workerGlobalScope);
+        }
     }
 
 private:
     WorkerRunLoopTask(const WorkerRunLoop& runLoop, PassOwnPtr<ExecutionContextTask> task)
         : m_runLoop(runLoop)
         , m_task(task)
     {
     }
 
     const WorkerRunLoop& m_runLoop;
@@ skipping 200 matching lines @@
 
 bool WorkerRunLoop::postDebuggerTask(PassOwnPtr<ExecutionContextTask> task)
 {
     bool posted = m_debuggerMessageQueue.append(WorkerRunLoopTask::create(*this, task));
     if (posted)
         postTask(TickleDebuggerQueueTask::create(this));
     return posted;
 }
 
 } // namespace WebCore