[ABANDONED] Enable V8 Promises

LayoutTests/crypto/resources/common.js

 // FIXME: Delete this (tests should import their own keys).
 function importTestKeys()
 {
     var data = asciiToUint8Array("16 bytes of key!");
     var extractable = true;
     var keyUsages = ['wrapKey', 'unwrapKey', 'encrypt', 'decrypt', 'sign', 'verify'];
 
     var hmacPromise = crypto.subtle.importKey('raw', data, {name: 'hmac', hash: {name: 'sha-1'}}, extractable, keyUsages);
     var aesCbcPromise = crypto.subtle.importKey('raw', data, {name: 'AES-CBC'}, extractable, keyUsages);
     var aesCbcJustDecrypt = crypto.subtle.importKey('raw', data, {name: 'AES-CBC'}, false, ['decrypt']);
@@ skipping 80 matching lines @@
 {
     if (error)
        debug(error);
     finishJSTest();
 }
 
 // =====================================================
 // FIXME: Delete the addTask() functions (better to test results directly)
 // =====================================================
 
-numOutstandingTasks = 0;
+var tasks = [];
 
-function addTask(promise)
+function runLoop()
 {
-    numOutstandingTasks++;
+    if (tasks.length === 0) {
+        finishJSTest();
+        return;
+    }
+    var task = tasks.shift();
+    task().then(runLoop);
+}
 
-    function taskFinished()
-    {
-        numOutstandingTasks--;
-        completeTestWhenAllTasksDone();
+function addTask(task)
+{
+    tasks.push(task);
+    if (tasks.length === 1) {
+        runLoop();
     }
-
-    promise.then(taskFinished, taskFinished);
 }
 
 function completeTestWhenAllTasksDone()
 {
-    if (numOutstandingTasks == 0) {
+    if (tasks.length === 0) {
         finishJSTest();
     }
 }
 
 function shouldRejectPromiseWithNull(code)
 {
-    var promise = eval(code);
-
     function acceptCallback(result)
     {
         debug("FAIL: '" + code + "' accepted with " + result + " but should have been rejected");
     }
 
     function rejectCallback(result)
     {
         if (result == null)
             debug("PASS: '" + code + "' rejected with null");
         else
             debug("FAIL: '" + code + "' rejected with " + result + " but was expecting null");
     }
 
-    addTask(promise.then(acceptCallback, rejectCallback));
+    addTask(function() {
+        var promise = eval(code);

[eroman, 2014/03/26 09:07:58]

In general this change is not a good idea, since "code" may not evaluate the
same if deferred (consider if it depends on globals which have changed since it
was called).

In practice it looks like the existing call sites don't have such issues. And
since I am actively removing this from the tests I am OK with this change.

+        return promise.then(acceptCallback, rejectCallback);
+    });
 }
 
 function shouldAcceptPromise(code)
 {
-    var promise = eval(code);
-
     function acceptCallback(result)
     {
         debug("PASS: '" + code + "' accepted with " + result);
     }
 
     function rejectCallback(result)
     {
         debug("FAIL: '" + code + "' rejected with " + result);
     }
 
-    addTask(promise.then(acceptCallback, rejectCallback));
+    addTask(function() {
+        var promise = eval(code);

[eroman, 2014/03/26 09:07:58]

Same comment as above.

+        return promise.then(acceptCallback, rejectCallback);
+    });
 }
 
 // =====================================================
 
 // Returns a Promise for the cloned key.
 function cloneKey(key)
 {
     // Sending an object through a MessagePort implicitly clones it.
     // Use a single MessageChannel so requests complete in FIFO order.
     var self = cloneKey;
@@ skipping 19 matching lines @@
     if (internals)
         debug("Serialized key bytes: " + bytesToHexString(internals.serializeObject(o)));
 }
 
 function shouldEvaluateAs(actual, expectedValue)
 {
     if (typeof expectedValue == "string")
         return shouldBeEqualToString(actual, expectedValue);
     return shouldEvaluateTo(actual, expectedValue);
 }