Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 209853007: Fix line height when changing multiplier. (Closed)

Created:
6 years, 9 months ago by skobes
Modified:
6 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink, esprehn
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update line height when changing multiplier. Line height is cached in the RenderBlock; when FTA updates a multiplier it needs to force recomputation of the line height. (The old autosizer avoids this issue by using setStyle instead of setStyleInternal. This triggers style recalc, which invalidates the line height.) BUG=353309, 354032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169975

Patch Set 1 #

Patch Set 2 : Rebaseline. #

Patch Set 3 : Accidentally fixed a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/FastTextAutosizer.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
skobes
6 years, 9 months ago (2014-03-24 23:53:14 UTC) #1
pdr.
On 2014/03/24 23:53:14, skobes wrote: Oh wow, this is a fantastic change. LGTM, but can ...
6 years, 9 months ago (2014-03-25 04:28:04 UTC) #2
skobes
On 2014/03/25 04:28:04, pdr wrote: > On 2014/03/24 23:53:14, skobes wrote: > > Oh wow, ...
6 years, 9 months ago (2014-03-25 17:35:38 UTC) #3
skobes
On 2014/03/25 04:28:04, pdr wrote: > On 2014/03/24 23:53:14, skobes wrote: > > Oh wow, ...
6 years, 9 months ago (2014-03-25 17:35:38 UTC) #4
pdr
On 2014/03/25 17:35:38, skobes wrote: > On 2014/03/25 04:28:04, pdr wrote: > > On 2014/03/24 ...
6 years, 9 months ago (2014-03-25 17:50:00 UTC) #5
pdr
SGTM! :)
6 years, 9 months ago (2014-03-25 17:50:31 UTC) #6
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 9 months ago (2014-03-25 18:10:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/209853007/40001
6 years, 9 months ago (2014-03-25 18:10:09 UTC) #8
skobes
The CQ bit was unchecked by skobes@chromium.org
6 years, 9 months ago (2014-03-25 18:23:46 UTC) #9
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 9 months ago (2014-03-25 18:24:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/209853007/120001
6 years, 9 months ago (2014-03-25 18:24:32 UTC) #11
commit-bot: I haz the power
Change committed as 169975
6 years, 9 months ago (2014-03-25 19:31:02 UTC) #12
vsevik
6 years, 9 months ago (2014-03-26 12:21:17 UTC) #13
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/212163006/ by vsevik@chromium.org.

The reason for reverting is: This might have caused android tests failure: 
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg...
Speculatively reverting it..

Powered by Google App Engine
This is Rietveld 408576698