Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 209853002: add setaccessorproperty to object (Closed)

Created:
6 years, 9 months ago by dcarney
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

add setaccessorproperty to object R=svenpanne@chromium.org LOG=N BUG=v8:2964 Committed: https://code.google.com/p/v8/source/detail?r=20178

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : gcc fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M include/v8.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
ptal
6 years, 9 months ago (2014-03-24 08:25:25 UTC) #1
Sven Panne
lgtm
6 years, 9 months ago (2014-03-24 08:41:17 UTC) #2
dcarney
6 years, 9 months ago (2014-03-24 08:42:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r20178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698