third_party/WebKit/Source/platform/inspector_protocol/Maybe.h - Issue 2098523002: Fix some issues found by coverity scans on Node.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Maybe.h

Issue 2098523002: Fix some issues found by coverity scans on Node.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/inspector_protocol/Maybe.h

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Maybe.h b/third_party/WebKit/Source/platform/inspector_protocol/Maybe.h

index 3fcd081d89f12a7e0d742dd2a2c1a0e349b290ab..cf372e0bbe2015cdbaff282615ce10041fcc30e2 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Maybe.h

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Maybe.h

@@ -18,7 +18,7 @@ class String16;

template<typename T>

class Maybe {

public:

- Maybe() { }

+ Maybe() : m_value() { }

Maybe(std::unique_ptr<T> value) : m_value(std::move(value)) { }

void operator=(std::unique_ptr<T> value) { m_value = std::move(value); }

T* fromJust() const { DCHECK(m_value); return m_value.get(); }

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/inspector_protocol/String16STL.h » ('j') | no next file with comments »