Issue 2098493002: WIP: Add custom platform library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2098493002: WIP: Add custom platform library. (Closed)

Created:
4 years, 6 months ago by Johnni Winther

Modified:
4 years ago

Reviewers:

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

WIP: Add custom platform library.

Patch Set 1 #

Patch Set 2 : Add argument. #

Total comments: 1

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
M	pkg/compiler/lib/src/dart2js.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View		1 chunk	+2 lines, -1 line	1 comment	Download
A	sdk/lib/_internal/js_runtime/lib/custom_patch.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A +	sdk/lib/custom.platform	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	sdk/lib/custom/custom.dart	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

4 years, 6 months ago (2016-06-23 12:45:16 UTC) #1

https://codereview.chromium.org/2098493002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2098493002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:2579: "custom":
"_internal/js_runtime/lib/custom_patch.dart"
All these should be part of the .platform file.

Expand Messages | Collapse Messages