src/heap/heap.cc - Issue 2098483002: [heap] Add CHECK for non-null object to LeftTrimFixedArray

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 2098483002: [heap] Add CHECK for non-null object to LeftTrimFixedArray (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 9c6029eadd3bb6f0eade26a96d75ff4c4659d391..40763a4f0092d278758a12d51ecf83ed5ffd42b6 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -3154,6 +3154,7 @@ void Heap::AdjustLiveBytes(HeapObject* object, int by, InvocationMode mode) {

FixedArrayBase* Heap::LeftTrimFixedArray(FixedArrayBase* object,

int elements_to_trim) {

+ CHECK_NOT_NULL(object);

DCHECK(!object->IsFixedTypedArrayBase());

DCHECK(!object->IsByteArray());

const int element_size = object->IsFixedArray() ? kPointerSize : kDoubleSize;

« no previous file with comments | « no previous file | no next file » | no next file with comments »