Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Issue 2098483002: [heap] Add CHECK for non-null object to LeftTrimFixedArray (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
Reviewers:
Camillo Bruni
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add CHECK for non-null object to LeftTrimFixedArray R=cbruni@chromium.org Committed: https://crrev.com/fc656803cadd37f63a599d1aaa503c5ce7a0785d Cr-Commit-Position: refs/heads/master@{#37216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Camillo Bruni
lgtm
4 years, 6 months ago (2016-06-23 12:23:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2098483002/1
4 years, 6 months ago (2016-06-23 12:23:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 12:48:31 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 12:51:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc656803cadd37f63a599d1aaa503c5ce7a0785d
Cr-Commit-Position: refs/heads/master@{#37216}

Powered by Google App Engine
This is Rietveld 408576698