SkPDF: SkPDFStream takes only SkStreamAsset

SkPDF: SkPDFStream takes only SkStreamAsset

This is possible since https://crrev.com/869763002. Later, I'll clean
up the logic and class constructors.  For now, I assert everywhere I
expect a SkStreamAsset to be well-behaved (duplcate, hasLength).
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2098393002

Committed: https://skia.googlesource.com/skia/+/29ed2ae2daa843c8ef955df34b26e672c67b14f3

[hal.canary, 2016-06-27 16:36:47]

Description was changed from

==========
SkPDF: SkPDFStream takes only SkStreamAsset

This is possible since https://crrev.com/869763002. Later, I'll clean
up the logic and class constructors.  For now, I assert everywhere I
expect a SkStreamAsset to be well-behaved (duplcate, hasLength).
==========

to

==========
SkPDF: SkPDFStream takes only SkStreamAsset

This is possible since https://crrev.com/869763002. Later, I'll clean
up the logic and class constructors.  For now, I assert everywhere I
expect a SkStreamAsset to be well-behaved (duplcate, hasLength).
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2098393002
==========

[hal.canary, 2016-06-27 16:36:54]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 16:37:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-06-27 16:38:13]

halcanary@google.com changed reviewers:
+ tomhudson@google.com

[hal.canary, 2016-06-27 16:38:14]

ptal

[commit-bot: I haz the power, 2016-06-27 16:57:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 16:57:16]

Dry run: This issue passed the CQ dry run.

[Tom Hudson, 2016-06-29 12:15:35]

tomhudson@chromium.org changed reviewers:
+ tomhudson@chromium.org

[Tom Hudson, 2016-06-29 12:15:36]

LGTM modulo:

the asserts and conditionals are technically unnecessary if you really have an
SkStreamAsset, right, since the class is defined as a Seekable with guaranteed
length? So I assume that's what you're proposing to clean up later.

What's the rush? Or do we have a bug to track that cleanup?

[hal.canary, 2016-06-29 13:13:31]

On 2016/06/29 12:15:36, Tom Hudson wrote:
> LGTM modulo:
> 
> the asserts and conditionals are technically unnecessary if you really have an
> SkStreamAsset, right, since the class is defined as a Seekable with guaranteed
> length? So I assume that's what you're proposing to clean up later.
> 
> What's the rush? Or do we have a bug to track that cleanup?

Officially, yes, but a client could write an implementation of SkStreamAsset
which doesn't follow the rules.

[hal.canary, 2016-06-29 13:13:36]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-06-29 13:13:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Hudson, 2016-06-29 13:14:50]

On 2016/06/29 13:13:31, Hal Canary wrote:
> Officially, yes, but a client could write an implementation of SkStreamAsset
> which doesn't follow the rules.

Ugh - YAGNI?

[hal.canary, 2016-06-29 13:16:53]

On 2016/06/29 13:14:50, Tom Hudson wrote:
> On 2016/06/29 13:13:31, Hal Canary wrote:
> > Officially, yes, but a client could write an implementation of SkStreamAsset
> > which doesn't follow the rules.
> 
> Ugh - YAGNI?

valid point.  I'll write the followup CL now.

[commit-bot: I haz the power, 2016-06-29 13:31:37]

Description was changed from

==========
SkPDF: SkPDFStream takes only SkStreamAsset

This is possible since https://crrev.com/869763002. Later, I'll clean
up the logic and class constructors.  For now, I assert everywhere I
expect a SkStreamAsset to be well-behaved (duplcate, hasLength).
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2098393002
==========

to

==========
SkPDF: SkPDFStream takes only SkStreamAsset

This is possible since https://crrev.com/869763002. Later, I'll clean
up the logic and class constructors.  For now, I assert everywhere I
expect a SkStreamAsset to be well-behaved (duplcate, hasLength).
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2098393002

Committed:
https://skia.googlesource.com/skia/+/29ed2ae2daa843c8ef955df34b26e672c67b14f3
==========

[commit-bot: I haz the power, 2016-06-29 13:31:38]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/29ed2ae2daa843c8ef955df34b26e672c67b14f3