Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: tools/perf/benchmarks/v8.py

Issue 2098373002: Disable v8.google on Nexus 5/7. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 import re 5 import re
6 6
7 from core import path_util 7 from core import path_util
8 from core import perf_benchmark 8 from core import perf_benchmark
9 from page_sets import google_pages 9 from page_sets import google_pages
10 10
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 cloud_storage_bucket=story.PARTNER_BUCKET) 291 cloud_storage_bucket=story.PARTNER_BUCKET)
292 story_set.AddStory(google_pages.AdwordCampaignDesktopPage(story_set)) 292 story_set.AddStory(google_pages.AdwordCampaignDesktopPage(story_set))
293 return story_set 293 return story_set
294 294
295 @classmethod 295 @classmethod
296 def Name(cls): 296 def Name(cls):
297 return 'v8.google' 297 return 'v8.google'
298 298
299 @classmethod 299 @classmethod
300 def ShouldDisable(cls, possible_browser): 300 def ShouldDisable(cls, possible_browser):
301 return cls.IsSvelte(possible_browser) # http://crbug.com/596556 301 if cls.IsSvelte(possible_browser): # http://crbug.com/596556
302 return True
303 # http://crbug.com/623576
304 if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or
305 possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'):
306 return True
307 return False
302 308
303 @classmethod 309 @classmethod
304 def ShouldTearDownStateAfterEachStoryRun(cls): 310 def ShouldTearDownStateAfterEachStoryRun(cls):
305 return True 311 return True
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698