content/browser/renderer_host/render_widget_host_view_aura.h - Issue 2098353005: Implement RenderWidgetHostViewBase::ImeCancelComposition for all Views (Aura Only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 2098353005: Implement RenderWidgetHostViewBase::ImeCancelComposition for all Views (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed the Incorrect DCHECK_EQ Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | content/browser/renderer_host/render_widget_host_view_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura.h

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h

index e71a472fd62e5af5af0de31144bac31e48232aea..1fb97586cdea0428fddddace86510fe4051597f1 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.h

+++ b/content/browser/renderer_host/render_widget_host_view_aura.h

@@ -142,7 +142,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura

void Focus() override;

void UpdateCursor(const WebCursor& cursor) override;

void SetIsLoading(bool is_loading) override;

- void ImeCancelComposition() override;

void ImeCompositionRangeChanged(

const gfx::Range& range,

const std::vector<gfx::Rect>& character_bounds) override;

@@ -473,6 +472,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAura

void OnUpdateTextInputStateCalled(TextInputManager* text_input_manager,

RenderWidgetHostViewBase* updated_view,

bool did_update_state) override;

+ void OnImeCancelComposition(TextInputManager* text_input_manager,

+ RenderWidgetHostViewBase* updated_view) override;

// cc::BeginFrameObserver implementation.

void OnBeginFrame(const cc::BeginFrameArgs& args) override;