Implement RenderWidgetHostViewBase::ImeCancelComposition for all Views (Aura Only)

content/browser/renderer_host/render_widget_host_view_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "content/browser/accessibility/browser_accessibility_manager.h"
 #include "content/browser/gpu/gpu_data_manager_impl.h"
@@ skipping 393 matching lines @@
 void RenderWidgetHostViewBase::TextInputStateChanged(
     const TextInputState& text_input_state) {
 // TODO(ekaramad): Use TextInputManager code paths when IME is implemented on
 // other platforms.
 #if defined(USE_AURA)
   if (GetTextInputManager())
     GetTextInputManager()->UpdateTextInputState(this, text_input_state);
 #endif
 }
 
+void RenderWidgetHostViewBase::ImeCancelComposition() {
+  if (GetTextInputManager())
+    GetTextInputManager()->ImeCancelComposition(this);

[kenrb, 2016/06/28 15:12:41]

I notice the method above this one has a USE_AURA guard, but that's not
necessary, right? GetTextInputManager() should return nullptr on non-Aura
platforms until it is implemented on them.

[EhsanK, 2016/06/28 16:41:19]

We always create TextInputManager now which is on all platforms. Therefore this
will never be null.

But that being said, there is no reason to have this code path in other
platforms now since TextInputManager has no observers (tab's view) in other
platforms.

I will enclose it in #ifdefs.

+}
+
 TextInputManager* RenderWidgetHostViewBase::GetTextInputManager() {
   if (text_input_manager_)
     return text_input_manager_;
 
   RenderWidgetHostImpl* host =
       RenderWidgetHostImpl::From(GetRenderWidgetHost());
   if (!host || !host->delegate())
     return nullptr;
 
   // This RWHV needs to be registered with the TextInputManager so that the
@@ skipping 17 matching lines @@
 
 bool RenderWidgetHostViewBase::IsChildFrameForTesting() const {
   return false;
 }
 
 cc::SurfaceId RenderWidgetHostViewBase::SurfaceIdForTesting() const {
   return cc::SurfaceId();
 }
 
 }  // namespace content