Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: tools/push-to-trunk/auto_roll.py

Issue 209833002: Fix options for calling push-to-trunk script. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 the V8 project authors. All rights reserved. 2 # Copyright 2013 the V8 project authors. All rights reserved.
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following 10 # copyright notice, this list of conditions and the following
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 def RunStep(self): 131 def RunStep(self):
132 print "Pushing lkgr %s to trunk." % self["lkgr"] 132 print "Pushing lkgr %s to trunk." % self["lkgr"]
133 self.PushTreeStatus("Tree is closed (preparing to push)") 133 self.PushTreeStatus("Tree is closed (preparing to push)")
134 134
135 # TODO(machenbach): Update the script before calling it. 135 # TODO(machenbach): Update the script before calling it.
136 try: 136 try:
137 if self._options.push: 137 if self._options.push:
138 P = push_to_trunk.PushToTrunk 138 P = push_to_trunk.PushToTrunk
139 self._side_effect_handler.Call( 139 self._side_effect_handler.Call(
140 P(push_to_trunk.CONFIG, self._side_effect_handler).Run, 140 P(push_to_trunk.CONFIG, self._side_effect_handler).Run,
141 ["-author", self._options.author, 141 ["--author", self._options.author,
142 "-reviewer", self._options.reviewer, 142 "--reviewer", self._options.reviewer,
143 "-revision", self["lkgr"], 143 "--revision", self["lkgr"],
144 "-force"]) 144 "--force"])
145 finally: 145 finally:
146 self.PushTreeStatus(self["tree_message"]) 146 self.PushTreeStatus(self["tree_message"])
147 147
148 148
149 class AutoRoll(ScriptsBase): 149 class AutoRoll(ScriptsBase):
150 def _PrepareOptions(self, parser): 150 def _PrepareOptions(self, parser):
151 parser.add_argument("-c", "--chromium", 151 parser.add_argument("-c", "--chromium",
152 help=("Deprecated.")) 152 help=("Deprecated."))
153 parser.add_argument("-p", "--push", 153 parser.add_argument("-p", "--push",
154 help="Push to trunk. Dry run if unspecified.", 154 help="Push to trunk. Dry run if unspecified.",
(...skipping 14 matching lines...) Expand all
169 CheckAutoRollSettings, 169 CheckAutoRollSettings,
170 CheckTreeStatus, 170 CheckTreeStatus,
171 FetchLKGR, 171 FetchLKGR,
172 CheckLastPush, 172 CheckLastPush,
173 PushToTrunk, 173 PushToTrunk,
174 ] 174 ]
175 175
176 176
177 if __name__ == "__main__": # pragma: no cover 177 if __name__ == "__main__": # pragma: no cover
178 sys.exit(AutoRoll(CONFIG).Run()) 178 sys.exit(AutoRoll(CONFIG).Run())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698